Universal Recovery Script
- Thread starter Bale
- Start date
maximillian the red
Member
Hoping someone can explain to me what I should look for to fix this:
as you can see it's choosing to use a bunch of MMJ to restore mana so it can cast a ton of tongue of the walrus. I do not have cocoon on this character, so tongue is my best healing spell, however i don't understand why it isn't using scroll of drastic healing (aside from being cheaper in the mall than 16 MMJs would be, I have some on hand so it's not a mall vs on-hand preference. Any help would be greatly appreciated, or if I can provide more details please let me know what you'd like to see.
gCLI said:
as you can see it's choosing to use a bunch of MMJ to restore mana so it can cast a ton of tongue of the walrus. I do not have cocoon on this character, so tongue is my best healing spell, however i don't understand why it isn't using scroll of drastic healing (aside from being cheaper in the mall than 16 MMJs would be, I have some on hand so it's not a mall vs on-hand preference. Any help would be greatly appreciated, or if I can provide more details please let me know what you'd like to see.
Bale
Minion
Judging by your maximum HP and MP you are in aftercore at approximately level 25.
In aftercore it does not care what items you have on hand. It only care if selling them in the mall will produce enough meat to purchase MMJ. Since the scroll is more expensive than 600 meat (current mall = 795), it will prefer to use the MMJ and hope you make more meat by selling your scrolls.
Anyway, I've been making small improvements to the script and now seems like a good time to release.
Changelog:
version 3.891 July 23, 2011
In aftercore it does not care what items you have on hand. It only care if selling them in the mall will produce enough meat to purchase MMJ. Since the scroll is more expensive than 600 meat (current mall = 795), it will prefer to use the MMJ and hope you make more meat by selling your scrolls.
Anyway, I've been making small improvements to the script and now seems like a good time to release.
Universal recovery v 3.891 released!
Changelog:
version 3.891 July 23, 2011
- Small bug fixed.
- Medicinal Herbs given greater precedence if you approve of using them.
(Because I've discovered that low skill characters really need to save the meat and aren't doing anything else with their spleens. I only wish they could be used when Bees hate me.)
Last edited:
The script used 22 MMJs total for max, and 16 to begin with. I'm guessing that since historical_price() returns 0 for MMJ and he already has them, they were considered free.
maximillian the red
Member
I guess I don't understand. The MMJ are "worth" 100 each, so it spent the equivalent of 1600 meat to heal me instead of the ~700 meat value of a scroll. That seems wrong. Good call on level by the way, mid level 25 doing basement. Perhaps the thing lostcalpolydude mentions, ie: that MMJ are considered free because I already have them is coming into play, but it seems like there should be a way to consider the value of the MMJ. Also, as i mentioned above, I also have scrolls on hand. Also, when you said:
did you miss that it used 16, not 6? or am i misunderstanding?
bale said:
did you miss that it used 16, not 6? or am i misunderstanding?
maximillian the red
Member
I don't. The only option i have selected in the bottom panel of the relay script is "Use MMJ in stock, even if it cannot be purchased this ascension" which I take to mean "don't worry about using something that I can't refill" - a sort of safety setting. that said, i have both mmj and scrolls in my inventory so i don't think it's a mall vs. inventory thing unless i dont understand how it's working.
Allucaneet
New member
Even if I still have my free rests per day, the script still buys the black cherry sodas. Are they cheaper than the free rests? The sodas are unchecked in the hp/mp restore checklist, if that will be helpful.
First of all, do you have "Free disco rest" checked in the Mafia HP/MP Usage tab, or in relay_Universal_Recovery.ash, and what is "Use free disco rests for" set to in relay_Universal_Recovery.ash?
Here is the code that control whether UR will use free rests for HP and MP:
This means that UR will use a free rest when restoring HP/MP if:
was meant to be
?
Here is the code that control whether UR will use free rests for HP and MP:
PHP:
if(contains_text(hpAutoRecoveryItems, "free disco rest")
&& (numeric_modifier("Base Resting MP") >= 10 || my_path() == "Bees Hate You"))
while(to_int(get_property("timesRested")) < disco && my_hp()<target
&& my_maxhp() - my_hp() >=rest_hp && (DiscoResting == "hp" || my_maxmp() - my_mp() >= rest_mp))
cli_execute("rest");
PHP:
if(contains_text(mpAutoRecoveryItems, "free disco rest")
&& (numeric_modifier("Base Resting MP") >= 10 || my_path() == "Bees Hate You"))
while(to_int(get_property("timesRested")) < disco && my_mp()<target
&& my_maxmp() - my_mp() >=rest_mp && (DiscoResting == "mp" || (my_maxhp() - my_hp())/2 >= rest_hp))
cli_execute("rest");- You authorized Mafia to use free rests for HP and/or MP
- You have a dwelling OR you are in a BHY run
- You have free rests left
- You HP/MP is lower than the target HP/MP
- You will not waste HP/MP by getting more than your max from resting
- "Use free disco rests for" is set to HP/MP OR you won't waste MP when resting to gain HP OR you won't gain more than half your missing HP when resting to gain MP
PHP:
(my_maxhp() - my_hp())/2 >= rest_hp)
PHP:
(my_maxhp() - my_hp())*2 >= rest_hp)
Theraze
Active member
Ran into an infinite loop bug with UR today... came in to this:
After adventuring once in the treasury (and getting a 500 meat NC):
That abort/failed is when I hit escape to stop it. The debug log was a stack overflow from it trying to cast DPN several hundred/thousand times.
After adventuring once in the treasury (and getting a 500 meat NC):
So... apparently it will loop if trying to remove bad effects and there isn't enough meat to do it?
Last edited:
Allucaneet
New member
The first four are okay. Perhaps the problem is in the fifth and sixth. I'll waste HP when resting to gain MP. I'll lower my target HP then.
Last edited:
igue
New member
Thanks slyz! That worked like a charm. Amazing.
maximillian the red
Member
I wont be able to supply any more debugging for the deal where it consumes MMJ and casts tongue instead of using a scroll of healing as that char has ascended (into a pasta run so i can get cocoon)
Captain Kirk
Member
I seem to be getting this error a lot today:
Invalid line in data file: "banana spritzer 0 0 40 100 0.0 70.0" (Universal_recovery.ash, line 137)
and this:
Invalid line in data file: "carbonated soy milk 0 0 70 80 0.0 75.0" (Universal_recovery.ash, line 137)
Invalid line in data file: "banana spritzer 0 0 40 100 0.0 70.0" (Universal_recovery.ash, line 137)
and this:
Invalid line in data file: "carbonated soy milk 0 0 70 80 0.0 75.0" (Universal_recovery.ash, line 137)