Bug - Fixed Maximizer won't equip Familiar Scrapbook

[SketchySolid]

I can't get maximizer to equip familiar scrapbook, even when explicitly telling it to with "+equip familiar scrapbook".

> maximize mainstat, +equip familiar scrapbook

Maximizer: mainstat, +equip familiar scrapbook
Maximizing...
7 combinations checked, best score 28.00 (FAIL)
Unable to meet all requirements via equipment changes.
See the Modifier Maximizer for further suggestions.

> /count familiar scrapbook

You have 1 familiar scrapbook.

 

[gausie]

r20750

 

[MCroft]

Thank Gausie. Now to try to figure out why it's not suggesting it...

 

[gausie]

It should be, no?

 

[MCroft]

I'd think so, but even some fairly obvious searches aren't turning it up:
Maximizer: +familiar weight, +familiar exp, +offhand, -tie, 2 dump
should consider it, but it's not in the list below...

I just need to debug it (while not also running autoscend!) and see what happens when it comes up. Debugging a loop through every item is a drag, because I haven't figure out how to be more surgical with IJ.

Also, my list of "things I want to do" includes "make the maximizer show the individual values for each individual item in the maximize string", but that hasn't hit "do this now" yet...

SLOT 3
[antique shield (5), Ouija Board, Ouija Board (5), reusable shopping bag (5), faded green protest sign (5), faded red protest sign (5), lead umbrella (5), pretty bouquet (5), detective skull (5), box (5), flaming talons (5), disturbing fanfic (5), star buckler (5), skull of the Bonerdagon (5), enchanted brass knuckles (5), easter egg balloon (5), magical ice cubes (5), hippo skin buckler (5), yakskin buckler (5), gnauga hide buckler (5), oyster basket (5), Glass Balls of the Goblin King (5), magic lamp (5), Cloaca-Cola shield (5), Dyspepsi-Cola shield (5), marionette (5), sock monkey (5), rag doll (5), rice bowl (5), Gazpacho's Glacial Grimoire (5), coffin lid (5), white satin shield (5), foon of fulmination (5), 1-ball (5), 2-ball (5), 3-ball (5), 4-ball (5), 5-ball (5), 6-ball (5), 7-ball (5), snarling wolf shield (5), snake shield (5), 9-ball (5), stuffed baby gravy fairy (5), stuffed flaming gravy fairy (5), stuffed frozen gravy fairy (5), stuffed stinky gravy fairy (5), stuffed spooky gravy fairy (5), stuffed sleazy gravy fairy (5), stuffed astral badger (5), stuffed MagiMechTech MicroMechaMech (5), stuffed hand turkey (5), stuffed snowy owl (5), stuffed scary death orb (5), stuffed mind flayer (5), stuffed undead elbow macaroni (5), stuffed Cheshire bitten (5), wicker shield (5), black shield (5), anniversary chutney sculpture (5), hors d'oeuvre tray (5), killer rag doll (5), incredibly creepy marionette (5), mad scientist's sock monkey (5), tropical paperweight (5), sewer turtle (5), sebaceous shield (5), box turtle (5), barskin buckler (5), clownskin buckler (5), demon buckler (5), Necrotelicomnicon (5), Cookbook of the Damned (5), Sinful Desires (5), sawblade shield (5), wonderwall shield (5), Tuesday's ruby (5), catskin buckler (5), battered hubcap (5), tip jar (5), borg sock monkey (5), handmade hobby horse (5), hobo code binder (5), spaghetti-box banjo (5), little round pebble (5), eelskin shield (5), Mer-kin takebag (5), rusty compass (5), The Spirit of Crimbo (5), parasitic strangleworm (5), penguin thesaurus (5), vinyl shield (5), glass gnoll eye (5), lucky lighter (5), Mer-kin roundshield (5), turtle wax shield (5), spiky turtle shield (5), turtling rod (5), padded tortoise (5), tortoboggan shield (5), ancient stone head (5), green peawee marble (5), brown crock marble (5), red China marble (5), lemonade marble (5), jet bennie marble (5), collapsible baton (5), ivory cue ball (5), sealhide buckler (5), eye of the Tiger-lily (5), snapdragon pistil (5), mole skin notebook (5), hot plate (5), scissor duck (5), flimsy clipboard (5), double-ice box (5), stress ball (5), plush hamsterpus (5), ancient calendar (5), orcish stud-finder (5), loadstone (5), Whatsian Ionic Pliers (5), oil lamp (5), giant penguin keychain (5), Mer-kin stopwatch (5), Mer-kin begsign (5), Engorged Sausages and You (5), smirking shrunken head (5), bone abacus (5), UV-resistant compass (5), security flashlight (5), sturdy cane (5), A Light that Never Goes Out (5), Half a Purse (5), third-hand lantern (5), red book (5), Elizabeth's Dollie (5), rubber ribcage (5), creepy doll head (5), creepy voice box (5), sommelier's towel (5), little black book (5), vampire pellet (5), radiator heater shield (5), heavy-duty clipboard (5), polyester pad (5), porcelain pepper mill (5), wicker clicker (5), bakelite bowl (5), low-budget shield (5), bread basket (5), dirty rigging rope (5), fireproof megaphone (5), basaltamander buckler (5), Heimz Fortified Kidney Beans (5), Mixed Garbanzos and Chickpeas (5), Hellfire Spicy Beans (5), World's Blackest-Eyed Peas (5), Trader Olaf's Exotic Stinkbeans (5), Pork 'n' Pork 'n' Pork 'n' Beans (5), Adventurer bobblehead (5), Science Notebook (5), sprinkle-begging cup (5), Silver HP-35 Calculator (5), spant shield (5), mime pocket probe (5), cosmetic football (5), portable dam (5), antique Canadian lantern (5), chalk chalice (5), terra cotta tambourine (5), velour valise (5), stained glass shield (5), drippy shield (5), Book of Old-Timey Carols (5), Crimbo smile (5), SalesCo sample kit (5), Red X Shield (5), novelty monorail ticket (5), aerogel attache case (5), burning paper crane (15)]
[burning paper crane, Red X Shield]

 

[AlbinoRhino]

My biggest suspicion is a conflict with the word "familiar" somewhere. It is a keyword as well. A quick scan of the items database indicates that there is another piece of equipment that contains the word, i.e. "flaming familiar doppelgänger" - which is a foldable and may have some special handling in the maximizer already.

I've never been able to completely understand the maximizer code and I could be way off. Just a guess.

 

[gausie]

I had noticed that also @AlbinoRhino! But in this case, it's because exp actually isn't coded to match against percentage experience gains. In r20751 maximizing for exp now assumes a monster's base exp is character's level * 2 and considers percentage exp buffs thusly

 

[AlbinoRhino]

Sweet...you're a wizard.