Manuel Progress (the relay version)

[wertperch]

I will look at making the edits and post a working version once I have one.

Thank you!

 

[fronobulax]

Try this.

It goes in dist\relay\mp_assets\script

If I had realized how trivial the edits were I would not have waited.

 

[matt.chugg]

Updated GIT main.ash from fonobulax - props

@fronobulax thanks for looking after this for me, I seem to have some time again these days so might get round to some updates on this, in the interests of preventing abandoned scripts (i've seen some other threads) I'm happy to give you collab access to this one, dm me your git username if you have one

 

[matt.chugg]

Updated to include dinos and wildfire paths and possibly some other paths that were waiting to be committed
Fixed a bug where NaN in appearance_rates() caused to_json() to fail

 

[Magus_Prime]

Thanks for the update. I got the following error after updating:

(mp_main.ash, line 556)
Script execution aborted (org.json.JSONException: JSON does not allow non-finite numbers.): (mp_main.ash, line 556)

running svn delete and then reinstalling fixed the problem.

 

[fronobulax]

(mp_main.ash, line 604)
Script execution aborted (org.json.JSONException: JSON does not allow non-finite numbers.): (mp_main.ash, line 604)

This is after a svn delete and a reinstall.

 

[matt.chugg]

(mp_main.ash, line 604)
Script execution aborted (org.json.JSONException: JSON does not allow non-finite numbers.): (mp_main.ash, line 604)

This is after a svn delete and a reinstall.

Interesting, that was something I thought I had fixed in the previous update, it was caused by something in the monster frequency data being null, there must be something else in the data structure that is null but it isn't coming from the monster frequency, I'll have a look

 

[gausie]

Should we fix NaN being in appearance_rates? Can you give an example

 

[matt.chugg]

> ash appearance_rates($location[The Hedge Maze])

Returned:    aggregate float [monster]
none => -1.0
topiary gopher => NaN
topiary    duck => NaN
topiary chihuahua herd => NaN
topiary kiwi => NaN

> ash appearance_rates($location[The Hedge Maze]).to_json()

()
Script execution    aborted (org.json.JSONException: JSON does not allow non-finite numbers.):    ()
Returned: void

 

[gausie]

Thanks! https://github.com/kolmafia/kolmafia/pull/1070

 

[gausie]

And merged, and thus fixed

 

[fronobulax]

And worked.

 

[matt.chugg]

Excellent, thanks everyone!