CounterChecker: Wormwood, Semi-rares, Dance Cards and more
- Thread starter Bale
- Start date
Theraze
Active member
tgetgel does sort of make a good point if it was in isolation, though I see the handling improved over his idea partially by the 1.4992 version, but... on your (Bale's) next version, maybe add +weapon, +offhand to the
line, so it only replaces your weapon? It makes sense to keep it as a maximize because then you can use the same basic code for all 3 cases...
1) Chapel. Special weapon.
2) 8-bit. Started with 2+ handed weapon.
3) 8-bit. Started with 1 handed weapon.
Problem is, in the case of 1, and only in the case of 1, we're currently maximizing their whole equipped gear, minus the two "equip me!" parts, based off the mafia tiebreaker and nothing else. No primestat, no melee/ranged damage, nothing... This could be fixed either by using tgetgel's idea of turning the maximize bits for case 1 into direct equips, or by adding the +weapon, +offhand I suggested to the line above. This would make it only equip the chapel weapon and CT without changing the rest of your gear.
But I don't see this as important enough to spin as a new patch, unless something else comes up. The released version should meet the needs of adventuring in the right spot, and you should get your gear back after that fight when it equips your backup outfit. It's just a matter of if you're still low-skill/stats on a SC ascension and end up without the ability to actually succeed for some reason.
Edit: Also related to this... the case 2 might not actually equip the CT, because it's only been given the weapon slot to replace (+weapon), though it's possible that it will equip offhand as well because it's being emptied when the weapon is equipped.
Code:
gear+= ", +equip "+chapel_weapon();1) Chapel. Special weapon.
2) 8-bit. Started with 2+ handed weapon.
3) 8-bit. Started with 1 handed weapon.
Problem is, in the case of 1, and only in the case of 1, we're currently maximizing their whole equipped gear, minus the two "equip me!" parts, based off the mafia tiebreaker and nothing else. No primestat, no melee/ranged damage, nothing... This could be fixed either by using tgetgel's idea of turning the maximize bits for case 1 into direct equips, or by adding the +weapon, +offhand I suggested to the line above. This would make it only equip the chapel weapon and CT without changing the rest of your gear.
But I don't see this as important enough to spin as a new patch, unless something else comes up. The released version should meet the needs of adventuring in the right spot, and you should get your gear back after that fight when it equips your backup outfit. It's just a matter of if you're still low-skill/stats on a SC ascension and end up without the ability to actually succeed for some reason.
Edit: Also related to this... the case 2 might not actually equip the CT, because it's only been given the weapon slot to replace (+weapon), though it's possible that it will equip offhand as well because it's being emptied when the weapon is equipped.
Morgan Blair
Member
Hooray!
But seriously, thanks for your hard work. Now I can go back to ignoring when and where my semi-rare adventures are taking place.
Theraze
Active member
Odd... it's supposed to be using this check, from my reading:
Ohhh... wait. There we are. It's just checking if the war is unstarted, or the sideDefeated != one of those specifics... but doesn't validate that the war has finished yet. Needs a warProgress check in that fratboys/both section.
Code:
case $location[Frat House]:
return available_amount($item[dingy dinghy]) > 0 && (get_property("warProgress") == "unstarted"
|| (get_property("sideDefeated") != "fratboys" && get_property("sideDefeated") != "both"));
Bale
Minion
Wait Therze, if a side is defeated, that means the war is over and there's no reason to check the exact number killed.. If the war isn't unstarted and a side has not lost, then it shouldn't try to go to the frat house! I don't get this.
Ed, what stage was the war at when you had the problem?
Ed, what stage was the war at when you had the problem?
Theraze
Active member
What I meant is that you need to have the check be more like the canadv code... zarqon has this:
Basically, the problem is that you're only checking if the war is unstarted or the frat aren't dead... you aren't validating on frat-not-dead that the war is over. So if the war is in progress, CounterChecker says that both Frat and Hippy are open, because warProgress != "unstarted" and sideDefeated isn't set yet...
Code:
case $location[Frat House]: return (itemcheck($item[dingy dinghy]) && get_property("warProgress") != "started" && get_property("sideDefeated") != "fratboys" && get_property("sideDefeated") != "both");Basically, the problem is that you're only checking if the war is unstarted or the frat aren't dead... you aren't validating on frat-not-dead that the war is over. So if the war is in progress, CounterChecker says that both Frat and Hippy are open, because warProgress != "unstarted" and sideDefeated isn't set yet...
Sorry I was afk so long. It was during the fighting itself, so neither the Frat House or Hippy Camp was accessible as not all their warriors were dead.
You guys are too fast for my testing. 1.4994 did indeed fix it. I'm in the same state and when a counter rolled around it went after massage oil instead, with a selling price that seemed a tad lower than I remember the quote for the hormones. Job well done.