All of that affects skills that you start with. None of it affects your daily absorb limit. Given that, one of those settings shouldn't exist, and both of those settings are irrelevant for this script.
All of that affects skills that you start with. None of it affects your daily absorb limit. Given that, one of those settings shouldn't exist, and both of those settings are irrelevant for this script.
Do I get to choose skills from a previous ascension to already possess at the beginning of an ascension?
cli_execute("svn update " + proj);
evil ed:
Could you replace the file chit.js in your relay folder with the attached experimental copy and tell us if it has any effect on the issue ? Since I can't seem to reproduce the issue myself, I need you to test this.
This may fix the problem that wertperch reported in post #1903 as well. I was seeing similar issues to his while doing some testing of this. I will commit this, experimentally, and see if it generates any new bug reports.
string normalize(string value, string type) {
if(value == "string")
return value;
string func = "to_" + type;
return call string func(value);
}
string normalize_prop(string value, string type) {
matcher list = create_matcher("(^|[,|])([^,|]*)", value);
buffer newlist;
while(list.find())
list.append_replacement(newlist, list.group(1) + normalize(list.group(2), type));
return newlist;
}
string define_property(string name, string type, string def) {
// All "built-in" properties exist. A "custom" property that doesn't exist uses the (normalized) default.
string normalized_def = normalize_prop(def, type);
if(!property_exists(name))
return normalized_def;
// The property exists and (potentially) overrides the default
string raw_value = get_property(name);
string value = normalize_prop(raw_value, type);
if(value == normalized_def)
remove_property(name);
else if(raw_value != value)
set_property(name, value);
return value;
}
It's completely fine with me if you want to take my code and adopt it and modify it and customize it to your taste.
Open source, and all that.
Thank you for telling me that I fixed all the deficiencies in the original set of "property" functions. I made the changes because I wanted something closer to how _I_ wanted them to behave - and I am sure that zarqon could/would have used them had they existed - but, having commit access to the KoLmafia source, it was easier to simply Make It So for my desired changes.
I like option 'TWO' myself. I wanted my chit settings to be "global" to begin with and didn't like that, when I decided to change something, I had to do it separately for each character.
ONE: ... If I do this, how long should I keep the migration code in place? I
var propDefault = 'original setting from bale';
// propDefault = 'change this and uncomment the line if you want a different default for all your characters';
define_property('prop','string',propDefault);
I like option TWO.
That said, I would probably just end up writing a small script to port over my settings from zlib vars to ChIT preferences anyway, so it would end up being THREE (with less work for Bale).