Adventure Advisor
- Thread starter Bale
- Start date
Here is an idea for the next update. I often open relay_AdventureAdvisor.ash to find out why it is advising me to go in a zone. Why not add a .reason field to the place record? I think there is enough space to have a "notes" column on the right, and it would help forgetful people by gently telling them that yes, even though I already finished that quest, I need to go to the Orc Chasm because I lack a lowercase n.
I still can't figure out why the script is advising me to go to the spooky forest though. The only place I can find where it is mentioned is:
It shouldn't get set to true, though:
Is there anything I am missing?
I still can't figure out why the script is advising me to go to the spooky forest though. The only place I can find where it is mentioned is:
PHP:
if(!hidden_temple_unlocked() && my_level() >=2)
kingdom["Spooky Forest"].useful = true;
Code:
> ashq if(!hidden_temple_unlocked() && my_level() >=2) print("useful"); else print("unuseful");
unusefulIs there anything I am missing?
Theraze
Active member
Could be that it's currently a bounty location?
Did notice one thing on the undersea locations though... it's checking for level > 13, not level >= 13, even though the sea unlocks when you get the SCUBA at level 13. Most people won't notice that its missing the zone, but... eh.
Did notice one thing on the undersea locations though... it's checking for level > 13, not level >= 13, even though the sea unlocks when you get the SCUBA at level 13. Most people won't notice that its missing the zone, but... eh.
Theraze
Active member
Since it seems to have gotten missed above... the underwater locations like
are off by a bit. Since they actually unlock at level 13, not 14. However, more accurately, they unlock when you complete the SCUBA gear, which is a quest item, so you could just test for that item. if(item_amount($item[makeshift scuba gear])>0) means useful on the undersea locations. Unfortunately mafia doesn't track the Sea Monkees at all, so you can't guarantee that the user has found little brother, big brother, and unlocked grandpa's zone, but the scuba gear is a more accurate check than looking at the level.
Code:
if(my_level() > 13) kingdom["Anemone Mine"].useful = true;
caphector
Member
> telescope
You have a telescope with 3 additional upgrades
Outer gate: locked gate (Locks Like the Raven/Black No. 2 - NEED)
Tower Guardian #1: best-selling novelist (plot hole - NEED)
Tower Guardian #2: the fickle finger of f8 (razor-sharp can lid - have)
Tower Guardian #3: pretty fly (spider web - have)
You have a telescope with 3 additional upgrades
Outer gate: locked gate (Locks Like the Raven/Black No. 2 - NEED)
Tower Guardian #1: best-selling novelist (plot hole - NEED)
Tower Guardian #2: the fickle finger of f8 (razor-sharp can lid - have)
Tower Guardian #3: pretty fly (spider web - have)
Bale
Minion
Adventure Advisor v 2.7.2 released!
Changelog:
version 2.7.2 April 25, 2012
- Fixed bug on questionably needed items when the telescope is incomplete
That bug was so weird that I cannot figure out if it is a bug in my script or a bug in KoLmafia. However I could figure out a better way to implement the function which doesn't have a bug.
Last edited:
A strange bug indeed. I could reduce the issue to the following code:
results in
EDIT:
Oh, I get it. test( 2, any_map ) actually calls test(int, string) instead of test(int, int[int])
I changed the code above to reflect that.
PHP:
# must be test(<something>, string)
void test( int something, string toprint )
{
print( "test( string, string ) called" );
print( "toprint = " + toprint );
}
# must have the same name as the function above
# (it must be an override)
void test( int whatever, int [int] m )
{
print( "test( int, int [int] ) called" );
test( whatever, m contains whatever? "yes": "no" );
}
int [int] any_map;
test( 2, any_map );
Code:
> call test.ash
test( string, string ) called
toprint = aggregate int [int]EDIT:
Oh, I get it. test( 2, any_map ) actually calls test(int, string) instead of test(int, int[int])
I changed the code above to reflect that.
Last edited: