Zlib Variable Manager
- Thread starter That FN Ninja
- Start date
zarqon
Well-known member
I just actually gave it a whirl -- it's quite handy! I really like the delete functionality (which is not in ZLib's CLI settings handling).
For improved usability I'd suggest a three-column table (documentation in the third column) and a smaller font for the setting names. I also like the idea of a "show more" link after the first n characters of the description, rather than "show/hide". I don't like needing to click for information -- I want it all visible and easy to read, so I tend to be picky about things like this.
I'm quite thrilled that you have taken this further -- it's been sitting in my to-do list forever, making me feel annoyed and incapable. So, thanks.
If you don't mind Ninja, I'll whip up the server-side script and then post a modified version of this script with that functionality added. You can then incorporate that functionality as you like. If you have any implementation issues after that, feel free to ask for changes in the server/script interaction.
Opera is a brilliant application and thanks to its popularity in the mobile arena is finally starting to earn more of the following that it deserves. It's one of the first things I install on any new machine (regardless of OS). I'm quite happy that you have joined our ranks.
For improved usability I'd suggest a three-column table (documentation in the third column) and a smaller font for the setting names. I also like the idea of a "show more" link after the first n characters of the description, rather than "show/hide". I don't like needing to click for information -- I want it all visible and easy to read, so I tend to be picky about things like this.
I'm quite thrilled that you have taken this further -- it's been sitting in my to-do list forever, making me feel annoyed and incapable. So, thanks.
If you don't mind Ninja, I'll whip up the server-side script and then post a modified version of this script with that functionality added. You can then incorporate that functionality as you like. If you have any implementation issues after that, feel free to ask for changes in the server/script interaction.
Opera is a brilliant application and thanks to its popularity in the mobile arena is finally starting to earn more of the following that it deserves. It's one of the first things I install on any new machine (regardless of OS). I'm quite happy that you have joined our ranks.
Interesting note -- the delete functionality was available in my original version (well, after several updates, but still before the spinoff scripts appeared). =D
Also, regarding the whole concept of "private" scripts -- wouldn't it be possible to create a function similar to load_current_map() in that it pulls the information from the server, but merges the datafiles, rather than override?
Also, regarding the whole concept of "private" scripts -- wouldn't it be possible to create a function similar to load_current_map() in that it pulls the information from the server, but merges the datafiles, rather than override?
That FN Ninja
Member
Descriptions?! That's a great idea! Why isn't I think of that? Thanks for the idea icon.
Yes, as heeheehee mentioned, all credit for delete functionality being included goes to him. I just didn't like the checkboxes for delete and having to have column headers to explain things so I overhauled the implementation.
Noted. However, I'm not sure about three columns. When I have a chance I'll whip up a version that has three columns and see how it looks. In the mean time, to have everything visible all that you need to do is click expand all descriptions and you're set.
Sounds great. I'm to the point where I'm ready to start testing the submission of documentation editing anyways.
Last edited:
Bale
Minion
Got it. Thanks.
halfvoid
Member
How does one change this value? I want to set it to 1000 by default and can't find it in my vars_ files.
AlbinoRhino
Active member
I was trying out relay_pref_manager.ash and it all seemed to work perfectly. Very handy ! Thanks. However, each time I loaded the script in the browser, this got printed to the CLI:
The zlib version doesn't do this.
I am curious as to what may be causing this.
The zlib version doesn't do this.
I am curious as to what may be causing this.
halfvoid
Member
Did you put the files in the relay folder instead of the scripts folder and call it from the relay browser?
AlbinoRhino
Active member
Yep. Everything seems to work fine too. Filter works. If I change something, it gets changed. Just that weird message whenever the relay page is first loaded.
AlbinoRhino
Active member
Certainly. One is from yesterday. The other I just made with the latest mafia revision.
Theraze
Active member
Well, from what it says, it seems to be trying to load/use something that doesn't exist... and whaddya know, I get the same thing now.
No clue what's causing it now. My suspicion would be somehow tied into the CCS settings, but... looks fine when you actually look at the preference... Hmm...
Edit: Ran the page with debug on, got a 9 meg log. seems this might be it:
Looks like it might be the implementation of check_version. It's giving that error when it tries to visit the url.
and for my log, same:
No clue what's causing it now. My suspicion would be somehow tied into the CCS settings, but... looks fine when you actually look at the preference... Hmm...
Edit: Ran the page with debug on, got a 9 meg log. seems this might be it:
Looks like it might be the implementation of check_version. It's giving that error when it tries to visit the url.
Last edited:
That FN Ninja
Member
You are welcome.
This is because the version tracking for PrefMan wasn't fully implemented. I added it in to v0.3. I still don't know what's going on with the CCS though.
Preference Manager v0.3 Update
Implemented version tracking. Now parses the descriptions of the properties from the KoLmafia wiki.
Theraze
Active member
From what it seemed from the debug logs, the CCS thing is just that the visit_url ended up with an incorrect check, which screws with the loading of values...
Edit: Okay... checked it out and for some reason, while it can be displayed if you manually run the check, customCombatScript will NOT display... that's why it's showing in the gCLI.
Workaround is to just skip it completely... tell the check not to try to show it, and it'll do everything else. No clue why it's considered different though... forcing it into to_string() did nothing, etc. Ah well. Anyways, workaround code... change this:
to this:
Doesn't remove any [current] functionality, as it doesn't display the CCS anyways, just skips trying. If ever it gets figured out why CCS doesn't display, the else if can be changed back to a pure else.
Edit: Okay... checked it out and for some reason, while it can be displayed if you manually run the check, customCombatScript will NOT display... that's why it's showing in the gCLI.
Workaround is to just skip it completely... tell the check not to try to show it, and it'll do everything else. No clue why it's considered different though... forcing it into to_string() did nothing, etc. Ah well. Anyways, workaround code... change this:
PHP:
if(def == "false" || def == "true")
set_property(setting, write_check(get_property(setting).to_boolean(), setting, "").to_string());
else{
attr("size=50");
set_property(setting, write_field(get_property(setting), setting, ""));
}
PHP:
if(def == "false" || def == "true")
set_property(setting, write_check(get_property(setting).to_boolean(), setting, "").to_string());
else if(setting != "customCombatScript"){
attr("size=50");
set_property(setting, write_field(get_property(setting), setting, ""));
}Doesn't remove any [current] functionality, as it doesn't display the CCS anyways, just skips trying. If ever it gets figured out why CCS doesn't display, the else if can be changed back to a pure else.
Last edited:
That FN Ninja
Member
Okay, thanks Theraze. I added the workaround for now. Didn't bump the version number.