Bug - Fixed r25831 - Debug Error when opening Relay Browser ("limitmode" is null)

fewyn

Administrator
Staff member
When opening the relay browser on r25381 it generates debug log and "The connection was reset" when it tries to actually open the browser. This happens with a fresh install and no relay scripts installed.

Code:
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
             KoLmafia r25831, Windows 10, Java 16.0.1
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Please note: do not post this log in the KoLmafia thread of KoL's
 Gameplay-Discussion forum. If you would like the KoLmafia dev team
 to look at it, please write a bug report at kolmafia.us. Include
 specific information about what you were doing when you made this
 and include this log as an attachment.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Timestamp: Tue Nov 02 15:17:29 EDT 2021
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 User: boxwhore
 Current run: 4436
 MRU Script: Unknown
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=


Unexpected error, debug log printed.
class java.lang.NullPointerException: Cannot invoke "java.lang.String.equals(java.lang.Object)" because "limitmode" is null
java.lang.NullPointerException: Cannot invoke "java.lang.String.equals(java.lang.Object)" because "limitmode" is null
    at net.sourceforge.kolmafia.request.RelayRequest.sendWarnings(RelayRequest.java:3373)
    at net.sourceforge.kolmafia.request.RelayRequest.run(RelayRequest.java:3340)
    at net.sourceforge.kolmafia.RequestThread.postRequest(RequestThread.java:206)
    at net.sourceforge.kolmafia.RequestThread.postRequest(RequestThread.java:171)
    at net.sourceforge.kolmafia.webui.RelayAgent.readServerResponse(RelayAgent.java:455)
    at net.sourceforge.kolmafia.webui.RelayAgent.performRelay(RelayAgent.java:103)
    at net.sourceforge.kolmafia.webui.RelayAgent.run(RelayAgent.java:82)

Full debug log: https://gist.github.com/fewyn/c06a27efd17fbdaa4916645081f54af9
 

fronobulax

Developer
Staff member
PR 181

replaced a compare between tow stings with equals() not realizing one string was allowed to be null. Fixed that.
 
Top