Bug - Fixed Lost in the Great Overlook Lodge +item test includes fairy bonus

AlbinoRhino

AlbinoRhino

Active member
It appears the spoiler for choice 2 is reporting my full +item%, rather than subtracting the familiar's portion of that bonus.
 
There's code to subtract fairy +item. It doesn't subtract clancy or eggman bonuses, but if you're actually using a familiar then more details are needed.

It also doesn't include +food drop.
 
I am using a Flaming Gravy Fairy. It also had a Li'l Businessman Kit equipped, which has +5% items itself, in case that makes a difference. Softcore, normal, Disco Bandit run.


Edit:

This was the modtrace I did:

mark v steam-hat +10.00 = 10.0
plexiglass pants +20.00 = 30.0
li'l businessman kit +5.00 = 35.0
fat leon's phat loot lyric +20.00 = 55.0
Fairy +67.62 = 122.62019202317981


The page was reporting "have 123%".
 
Last edited:
Fixed in 11994. That code really shouldn't be where it is, as already noted in the comment that was there, but for now it works...
 
I am not sure this is working. I'm running 11994 and modtrace item gives the following:

source
staff of the healthy breakfast


+10.00 = 10.0

celestial vision


+30.00 = 40.0

joyful resolve


+15.00 = 55.0

Eggman


+75.00 = 130.0

[TD="colspan: 2"] Item Drop Penalty [/TD]
[TD="colspan: 2"] Item Drop [/TD]
[TD="colspan: 2"] Sporadic Item Drop [/TD]

However the choice spoiler shows "[SIZE=-1](need +50 item drop, have 180%)" which is in fact 50 more than I have[SIZE=-1]...[/SIZE][/SIZE]
 
Ahh yes, the pan. Didn't think about that. WHy didn't that show up in the "modtrace item"? Or do you need to specifically look for "modtrace food drop"?
 
"Food Drop" doesn't have "item" anywhere in it. I guess when I track down why Eggman isn't being processed (I'm waiting on sea content before I ascend again, so it could be a while), I can list +food separately.
 
I am back at this adventure, this time on a 100% stinky gravy fairy run (29 lbs.). SCNP disco bandit again.


source
mark v steam-hat +10.00 = 10.0
baron von ratsworth's monocle +10.00 = 20.0
mad looting skillz +20.00 = 40.0
fat leon's phat loot lyric +20.00 = 60.0
Fairy +65.94 = 125.93745109543173

[TD="colspan: 2"] Item Drop Penalty[/TD]
[TD="colspan: 2"] Item Drop[/TD]
[TD="colspan: 2"] Sporadic Item Drop[/TD]


The choice spoiler says "[SIZE=-1](need +50 item drop, have 78%)".[/SIZE] Should it say "60%", or am I missing something here ?

Edit: Modtrace food drop = 0
 
Last edited:
My guess would be that the bonus from your fairy isn't being calculated properly for the purpose of subtracting its +item. I think there was getEffectiveWeight() that might need to be used instead of getWeight().
 
Fixed for Avatars of Jarlsberg in r11995.

Can someone confirm this works for paths with regular familiars too?
 
slyz said:
Fixed for Avatars of Jarlsberg in r11995.

Can someone confirm this works for paths with regular familiars too?
Click to expand...


r12003. As AT, Baby Gravy Fairy, 34 lbs. (5 from sympathy, 5 from leash, 5 from heavy petting).


source
mark v steam-hat +10.00 = 10.0
plexiglass pants +20.00 = 30.0
baron von ratsworth's monocle +10.00 = 40.0
mad looting skillz +20.00 = 60.0
peeled eyeballs +15.00 = 75.0
hustlin' +10.00 = 85.0
fat leon's phat loot lyric +20.00 = 105.0
Fairy +74.24 = 179.2434966208793

[TD="colspan: 2"] Item Drop Penalty[/TD]
[TD="colspan: 2"] Item Drop[/TD]
[TD="colspan: 2"] Sporadic Item Drop[/TD]


Page is reporting "[SIZE=-1](need +50% item drop, have 105%)". Assuming I understand how it is supposed to work[/SIZE], it looks right to me. Thanks to you all for working it out !
 
You must log in or register to reply here.
Back
Top