EatDrink.ash: Optimize your daily diet (and see how your old diet stacks up).
- Thread starter dj_d
- Start date
jtn2002
New member
I think my VoA is set at 1000, which is roughly what I get from castlefarming. I also don't think I changed either of those settings. Some of my accounts have yet to get the puppy and olfaction, others have both; so if a "use_lucre" boolean were implemented; that would be a huge help for me! Thanks, Theraze!
Theraze
Active member
It's a part of the using of coinmasters, since it's a... hmm...
Any chance you've changed eatdrink_priceOfNontradeables? This sets the value on anything that can't be purchased from the mall or npcs, and isn't a quest item. It defaults to MAXMEAT, which gets set earlier to
999 million. Changing either MAXMEAT or eatdrink_priceOfNontradeables would potentially affect the selection of bounty hunter items.
Tussosedan
New member
I'm only just starting to use EatDrink, and it looks awesome.
However, I can't understand some of the choices:
Things that bother me (and please forgive me if it's been answered before -- I did search):
1. Why is lasagna not chosen (with field gar)?
2. Why is the glimmering roc chosen over coffee pixie sticks, which are much cheaper?
3. Why is the nightcap a corpse on the beach, and not a bucket of wine?
Thanks!
However, I can't understand some of the choices:
Things that bother me (and please forgive me if it's been answered before -- I did search):
1. Why is lasagna not chosen (with field gar)?
2. Why is the glimmering roc chosen over coffee pixie sticks, which are much cheaper?
3. Why is the nightcap a corpse on the beach, and not a bucket of wine?
Thanks!
I'm not sure EatDrink knows about field gar.
Eating a glimmering roc feather will net you (adv*VoA-cost) meat, where VoA = value of adventure (1200 for you). Divide this by the amount of spleen used to get a basis to which you can compare other spleen items.
Glimmering roc feather value: (8*1200-4900)/4 = 1175 meat gained per spleen
Coffee pixie stick value : (7.5*1200-10*349)/4 = 1377.5 meat gained per spleen
I guess it should be buying coffee pixie sticks. Maybe there is a problem with the way items sold by coinmasters are valued?
Which version of EatDrink are you using? Maybe the problem has been fixed in one the versions Theraze posted recently?
For overdrinking, the value is the same except you don't divide by the drunkness when comparing different nightcaps.
bucket of wine value: 18*1200 - 8900 = 12700
corpse on the beach value: 22*1200 - 10600 = 15800
With a VoA of 1200 meat per adventure, a corpse on the beach will net you more meat.
Theraze
Active member
I don't think we have the special handling for field gar yet... we talked about that around posts 1362-1365. We trust mafia's information... does mafia update its stats if you drink the potion? That's part of what we need to know for making this work right.
Base for Knob chow mein: 25*3 = 75 adventures.
Base for gnat lasagna: 14*5 = 70 adventures.
Boosted for gnat lasagna: 19*5 = 95 adventures.
So yeah... without the field gar being considered, it makes more sense to pick the chow mein. With it, gnat lasagna (as the cheapest lasagna option) should have been picked, as long as mafia's adventure data updates when the effect is on. If it doesn't update when the effect is on, then we need to do our own override. And that's the answer to number 1.
Game grid tickets cost 349 and you need 10, so total cost is 3490. This provides 7.5 average adventures for 4 spleen.
The roc feather cost 4900 meat and provides 8 average adventures for 4 spleen.
Pixie sticks gave 7.5*1200=9000. 9000-3490=5510. 5510/4=1377.5.
Roc feather gives 8*1200=9600. 9600-4900=4700. 4700/4=1175.
Honestly, no clue why it picked the roc feathers over coffee pixie sticks.
Would take more logging to show why. Any chance you can run these two lines and give me the results?
1) decide how much the coffee pixie sticks will cost to completely acquire, and
2) decide if we have the ability to actually get the game grid tokens to purchase the pixie sticks.
Corpse on the beach... hmm... comparison time again!
Corpse is 22*1200=26400. Cost means 26400-10600=15800 total value, as shown.
Bucket is 18*1200=21600. Cost means 21600-8900=12700 total value, which is worse.
Problem with that logic is that for overdrinking, the value of ode actually matters, unlike with normal boozing. With normal boozing, doesn't matter if you use a bucket of wine to get from 0-10 or 10 imported beer, you're getting the extra adventure from ode. Actually in that comparison, the beer is better because you get 30 adventures for 2000 meat instead of 28 adventures for 8900 meat. But that's somewhat besides the point, which is that in normal boozing, you want the cheapest alcohol that, irregardless of ode, provies the most adventures. With nightcaps, you want the cheapest alcohol that, in concert with ode, provides the most adventures.
Guess that means I'm going to have to overload the value check for overdrinking and have it actually boost them both up to 28*1200 and then the value flip-flops. So that's why number 3 happened... because they're working off base drink adventure values, not bumped by ode. I'll need to look at that in the next day or two.
Base for Knob chow mein: 25*3 = 75 adventures.
Base for gnat lasagna: 14*5 = 70 adventures.
Boosted for gnat lasagna: 19*5 = 95 adventures.
So yeah... without the field gar being considered, it makes more sense to pick the chow mein. With it, gnat lasagna (as the cheapest lasagna option) should have been picked, as long as mafia's adventure data updates when the effect is on. If it doesn't update when the effect is on, then we need to do our own override. And that's the answer to number 1.
Game grid tickets cost 349 and you need 10, so total cost is 3490. This provides 7.5 average adventures for 4 spleen.
The roc feather cost 4900 meat and provides 8 average adventures for 4 spleen.
Pixie sticks gave 7.5*1200=9000. 9000-3490=5510. 5510/4=1377.5.
Roc feather gives 8*1200=9600. 9600-4900=4700. 4700/4=1175.
Honestly, no clue why it picked the roc feathers over coffee pixie sticks.
Would take more logging to show why. Any chance you can run these two lines and give me the results?
Those are the two checks used to:
1) decide how much the coffee pixie sticks will cost to completely acquire, and
2) decide if we have the ability to actually get the game grid tokens to purchase the pixie sticks.
Corpse on the beach... hmm... comparison time again!
Corpse is 22*1200=26400. Cost means 26400-10600=15800 total value, as shown.
Bucket is 18*1200=21600. Cost means 21600-8900=12700 total value, which is worse.
Problem with that logic is that for overdrinking, the value of ode actually matters, unlike with normal boozing. With normal boozing, doesn't matter if you use a bucket of wine to get from 0-10 or 10 imported beer, you're getting the extra adventure from ode. Actually in that comparison, the beer is better because you get 30 adventures for 2000 meat instead of 28 adventures for 8900 meat. But that's somewhat besides the point, which is that in normal boozing, you want the cheapest alcohol that, irregardless of ode, provies the most adventures. With nightcaps, you want the cheapest alcohol that, in concert with ode, provides the most adventures.
Guess that means I'm going to have to overload the value check for overdrinking and have it actually boost them both up to 28*1200 and then the value flip-flops.
So that's why number 3 happened... because they're working off base drink adventure values, not bumped by ode. I'll need to look at that in the next day or two.
Tussosedan
New member
Thanks for the quick response!
I got:
Looks like I need to actually own a game grid ticket for it to work:
So since I usually don't have extra tickets, it won't consider buying them?
I got:
Looks like I need to actually own a game grid ticket for it to work:
So since I usually don't have extra tickets, it won't consider buying them?
Theraze
Active member
On a positive note, do have the overdrink problem solved... fixed version attached to this post, but there'll probably be an edit or two today to try to get coinmasters fixed up. Unless people post after this, in which case I'll dump in a new post instead of editing.
Anyways, for people who care... the way I fixed up overdrink is by turning the milk_do_body_good, lunch_do_body_good, and ode_do_liver_good into booleans with a check variable passed into it. If you're checking, it will tell you whether or not you can get milk/lunch/ode for that size item. Then the value check, inside its overdrink check where it multiplies it back out into best-single-item checking adds the size of item*VoA to value. Tested and it wanted a bucket of wine, displayed value was properly at 26520 for my 1250 VoA with default stat values.
Regarding coinmasters... nope, means we need to change up that check. The available_amount I was hoping to look at mallables isn't. It would buy them if needed, but it eliminates it as a valid possibility because available_amount is less than the amount needed.
Edit: Try this version. Should fix the coinmaster issue. Changed from available_amount(coinmaster.item) to coinmaster.available_tokens and put a check for EAT_MALL as an alternative... if you have access to the mall, consider the tokens to be attainable. Not necessarily true, but in my brief testing this did get pixie sticks on an aftercore character and realized it was impossible for in-ronin characters. I'll need to consider how better to do the check to be more accurate later.
Edit2: This version should be even better. Threw in a check for effective_price(con.it.seller.item, false) > 0, so it should only try to use coinmaster items outside your inventory if you can actually acquire more and have access to the mall. This MIGHT have issues if they make a coinmaster whose items can always be purchased from an NPC shop with meat... but so far, so good.
Anyways, for people who care... the way I fixed up overdrink is by turning the milk_do_body_good, lunch_do_body_good, and ode_do_liver_good into booleans with a check variable passed into it. If you're checking, it will tell you whether or not you can get milk/lunch/ode for that size item. Then the value check, inside its overdrink check where it multiplies it back out into best-single-item checking adds the size of item*VoA to value. Tested and it wanted a bucket of wine, displayed value was properly at 26520 for my 1250 VoA with default stat values.
Regarding coinmasters... nope, means we need to change up that check. The available_amount I was hoping to look at mallables isn't. It would buy them if needed, but it eliminates it as a valid possibility because available_amount is less than the amount needed.
Edit: Try this version. Should fix the coinmaster issue. Changed from available_amount(coinmaster.item) to coinmaster.available_tokens and put a check for EAT_MALL as an alternative... if you have access to the mall, consider the tokens to be attainable. Not necessarily true, but in my brief testing this did get pixie sticks on an aftercore character and realized it was impossible for in-ronin characters. I'll need to consider how better to do the check to be more accurate later.
Edit2: This version should be even better. Threw in a check for effective_price(con.it.seller.item, false) > 0, so it should only try to use coinmaster items outside your inventory if you can actually acquire more and have access to the mall. This MIGHT have issues if they make a coinmaster whose items can always be purchased from an NPC shop with meat... but so far, so good.
Last edited:
Tussosedan
New member
Great! Now it does choose coffee pixie sticks and a bucket of wine for me.
Only the field gar thing left, and then I'll turn over my diet
But I suppose it's problematic, since it always needs to check the Arizona time to see if the effect is active.
Only the field gar thing left, and then I'll turn over my diet
But I suppose it's problematic, since it always needs to check the Arizona time to see if the effect is active.
I forget where I stole it from, but I use the following in my consuming script:
"lun" is for lundi (monday in french), so I guess it should be replaced with "mon". I'm not sure how this could be used to check for Arizona time though.
PHP:
if ( now_to_string("EEE").contains_text( "lun" ) )Theraze
Active member
Yeah... what I need to check is if the tuesday's ruby (which changes its modifier based on the day) changes based on rollover or based on the Arizona-day. If it's based on Arizona-day, full success... can just do
If the first few hours of tomorrow's rollover are still with the new tuesday ruby modifier, then that's no good... I'll need to do some sort of blend of gametime_to_int() and the numeric modifier to make it right. Let's see... rollover is 8:30PM Arizona time, so it would be good from 3.5 hours into muscle percent until 3.5 hours into 3-7 mp restoration. More complicated, but it should work. Also, unlike using now_to_string(), it shouldn't cause problems for people using non-English localized computers.
Logic time...
Edit: Well, according to mafia, the field gar potion and Tuesday's ruby (Modifiers.java, override function) both use the same date check. As such, I should be able to use the simple muscle check listed above to decide if lasagna can be improved...
Edit2: Wiki's talk page says that people have tried it and it's definitely tied into Arizona day-time, not rollover. Will need to validate that all is well with Tuesday's ruby regarding that, but I'll start tweaking up the support. Does look like mafia's got it all sorted though.
means that it's Monday.
If the first few hours of tomorrow's rollover are still with the new tuesday ruby modifier, then that's no good... I'll need to do some sort of blend of gametime_to_int() and the numeric modifier to make it right. Let's see... rollover is 8:30PM Arizona time, so it would be good from 3.5 hours into muscle percent until 3.5 hours into 3-7 mp restoration. More complicated, but it should work. Also, unlike using now_to_string(), it shouldn't cause problems for people using non-English localized computers.
Logic time...
So each hour is 3.6 million bits there. And since we want 3.5 hours, but we don't want to convert it into a float...
12.6 million in is our cutoff. If we put the gametime_to_int() check for >=12.6 million and muscle or <12.6 million and MP regen, we should be good. If we need to make it complicated, which I won't know until tonight, as long as I remember to check it. Meh.
Edit: Well, according to mafia, the field gar potion and Tuesday's ruby (Modifiers.java, override function) both use the same date check. As such, I should be able to use the simple muscle check listed above to decide if lasagna can be improved...
Edit2: Wiki's talk page says that people have tried it and it's definitely tied into Arizona day-time, not rollover. Will need to validate that all is well with Tuesday's ruby regarding that, but I'll start tweaking up the support. Does look like mafia's got it all sorted though.
Last edited:
Theraze
Active member
Main work is done... the problem is in predicting whether or not we'll be wanting multiple lasagnas. Here we hit a user-vote time:
Do we want to consider people eating multiple lasagnas as likely, if they're going for the effect, and work based on remaining fullness for EatDrink to consume / lasagna size, or to work individually?
Individually, the lasagnas are less likely to start going, since it currently costs 8900 for a field gar potion, and and it takes a VoA of over 1780 to make it worthwhile for a single lasagna.
Working as a maximum group, it will very often consume the potion if you're in aftercore, because 4-6 lasagnas and 20-30 bonus adventures are a good thing and definitely worth the 9-10k.
My current function runs as function(int lasagnas, boolean check), so I can tell it how many lasagnas of 5 bonus adventures to consider, so it's easy to tweak for later, but... either way it's likely to go off, either missing opportunities because it's considering them individually or by buffing when it's not as effective as it should be. My goal is to have it be as correct as possible, so that you don't even realize that it got confused.
Do we want to consider people eating multiple lasagnas as likely, if they're going for the effect, and work based on remaining fullness for EatDrink to consume / lasagna size, or to work individually?
Individually, the lasagnas are less likely to start going, since it currently costs 8900 for a field gar potion, and and it takes a VoA of over 1780 to make it worthwhile for a single lasagna.
Working as a maximum group, it will very often consume the potion if you're in aftercore, because 4-6 lasagnas and 20-30 bonus adventures are a good thing and definitely worth the 9-10k.
My current function runs as function(int lasagnas, boolean check), so I can tell it how many lasagnas of 5 bonus adventures to consider, so it's easy to tweak for later, but... either way it's likely to go off, either missing opportunities because it's considering them individually or by buffing when it's not as effective as it should be. My goal is to have it be as correct as possible, so that you don't even realize that it got confused.
Theraze
Active member
Yeah... what I think I'll probably do is start with gar(floor(totalroom / 3)) lasagnas for the check, and follow up with gar(actual lasagna count) for the decision if we're actually going to get and use the potion. It MIGHT cause it to decide on lasagnas and fail to potion if you're RIGHT near the edge and are REALLY low on meat... as in, not enough to afford to get the lasagnas, milk, and gar potion... but shouldn't get noticed by most people, and gives the maximum chances for accuracy. Unless someone thinks of a better system soonish.
Edit: Just these three, right?
Edit: Just these three, right?
Code:
if ($items[fishy fish lasagna, gnat lasagna, long pork lasagna] contains position[i].it)
foodlasagna += 1;
Last edited:
Tussosedan
New member
Tested today, using the latest mafia build (10849):
At 11:27pm Monday (MST) - Time in Phoenix, AZ, USA:
But KoL shows:
And the new EatDrink chooses lasagnas.
At 12:08am Tuesday (MST) - Time in Phoenix, AZ, USA:
Same results, but KoL shows:
So I suppose mafia's check for the ruby is no good?
Didn't check if it actually disallows using the field gar potion.
Edit: filed a bug report.
Edit 2:
Now that I took a closer look at your results, shouldn't it choose 6 lasagnas and a stomach turnover instead of the 4 lasagnas with hot hi mein and super ka-bob for you?
At 11:27pm Monday (MST) - Time in Phoenix, AZ, USA:
But KoL shows:
And the new EatDrink chooses lasagnas.
At 12:08am Tuesday (MST) - Time in Phoenix, AZ, USA:
Same results, but KoL shows:
So I suppose mafia's check for the ruby is no good?
Didn't check if it actually disallows using the field gar potion.
Edit: filed a bug report.
Edit 2:
Now that I took a closer look at your results, shouldn't it choose 6 lasagnas and a stomach turnover instead of the 4 lasagnas with hot hi mein and super ka-bob for you?
Last edited:
Theraze
Active member
Yes, incorrect Arizona day-detection would be a mafia bug, detecting those based on rollover time rather then Arizona time. Should be easy to fix, just changing the GMT-3.5 to a GMT-7... if nobody's come up with one soonish, I'll try to proffer a patch that the devs can check on.
The reason for stopping after 4 lasagnas is because I set stepmeat to 20k, and it costs 4.7k to buy a lasagna. After 4 lasagnas, I've spent all but 1,108 of my meat, so the hot hi mein and super ka-bob are what it managed to get from my inventory or spending that much meat. For maximum adventures, set stepmeat to -1 and it will keep spending until it hurts.
Also, attaching a slightly more better-er version of the EatDrink here. I realized eventually that the existing one tries to get the potion during the check, before we actually know if we want it or not... if we can get it, we probably want it, but the above version might cause problems for people who have the summon clip art skill and don't have access to making lasagna. That's bad. And hence, the attached version of ED.
The reason for stopping after 4 lasagnas is because I set stepmeat to 20k, and it costs 4.7k to buy a lasagna. After 4 lasagnas, I've spent all but 1,108 of my meat, so the hot hi mein and super ka-bob are what it managed to get from my inventory or spending that much meat. For maximum adventures, set stepmeat to -1 and it will keep spending until it hurts.
Also, attaching a slightly more better-er version of the EatDrink here. I realized eventually that the existing one tries to get the potion during the check, before we actually know if we want it or not... if we can get it, we probably want it, but the above version might cause problems for people who have the summon clip art skill and don't have access to making lasagna. That's bad. And hence, the attached version of ED.