Bug - Fixed Bang potion types persisting and conflicting across characters

I've been working in the gummi mines, running the (bang) potion of detection all the live long day, and it seems that mafia is somehow remembering what the 1st character's potion is and it is causing a conflict with the second one I logged in (with the same instance of mafia, after logging out the first)

Code:
> use 34 potion of detect

cloudy     potion of detection
fizzy potion of detection

[potion     of detect] has too many matches.

> !

milky:     mental acuity
swirly: confusion (have 26)
bubbly: teleportitis (have     30)
smoky: healing (have 45)
cloudy: detection
effervescent:     sleepiness (have 31)
fizzy: inebriety (have 37)
dark: blessing (have     42)
murky: ettin strength (have 27)

If it wasn't clear from what I said before, the fizzy potion is the appropriate potion for the character I logged in and ran turns for first. I verified with a bricko fight that cloudy=detection and fizzy=inebriety for this character. Closing mafia completely and opening a new instance fixes the issue.
 

slyz

Developer
After Veracity fixed this bug, I thought about asking if what you describe could happen but for some reason I never posted. My guess is that r10150 is the cause.
 

Veracity

Developer
Staff member
My guess is that r10150 is the cause.
Heh.

When I was working on that, I specifically asked myself if bang potions would be affected. I wasn't able to find where the identified bang potion names got entered into the item name to id mapping table (if, in fact, they do), so concluded there was some other mechanism.

I'll look some more, by and by.
 

Veracity

Developer
Staff member
Well, something's funky.

Sending login request...
Initializing session for Brianna...
Refreshing session data...
...

> !

milky: ettin strength (have 0, 9 in closet)
swirly: blessing (have 0, 7 in closet)
bubbly: teleportitis (have 14)
smoky: detection (have 0, 14 in closet)
cloudy: healing (have 0, 11 in closet)
effervescent: sleepiness (have 0, 11 in closet)
fizzy: inebriety (have 0, 6 in closet)
dark: confusion (have 0, 10 in closet)
murky: mental acuity (have 0, 14 in closet)

> buy 1 potion of detection

Searching for "smoky potion"...
Search complete.
Purchasing smoky potion of detection (1 @ 120)...
You acquire an item: smoky potion of detection
Purchases complete.
...
Logout request submitted.
...
Sending login request...
Initializing session for Veracity...
Refreshing session data...
...

> !

milky: healing (have 4)
swirly: sleepiness (have 4)
bubbly: detection (have 4)
smoky: confusion (have 4)
cloudy: blessing (have 4)
effervescent: mental acuity
fizzy: inebriety (have 1)
dark: ettin strength (have 8)
murky: teleportitis (have 5)

> buy 1 potion of detection

bubbly potion of detection
smoky potion of detection

[potion of detection] has too many matches.
 
Top