Bug All skills with daily limits should appear in dailylimits.txt

[fronobulax]

From a PR on GitHub

we still report have_skill($skill[whatever]) as true if you can no longer cast the skill. The uncastability is stored in $skill[whatever].dailylimit. Or it should be, some skills aren't wired up correctly.

This is probably because of skills that are not in dailylimits.txt

Posting here as a reminder.

 

[eegee]

Fixed one case in r29079

 

[Ryo_Sangnoir]

You fixed one case, I'm reasonably sure there will be more.

 

[eegee]

I tried to do a full scan. If you can find more, please let me know.

 

[Ryo_Sangnoir]

Calculate the Universe isn't in there, for example.

How did you do your full scan?

 

[eegee]

I tried diff'ing modifiers.txt "Conditional Skill" entries against dailylimits.txt (for non-combat) but only added BCZ (and then removed) and the moss medal. Still a fix, but not a complete fix. I leave this here for further investigation:

[7418] Make Sweat-Ade
[7419] Drench Yourself in Sweat
[7420] Sip Some Sweat
[7499] Brandish Moss Medal
[7549] Pull down your crepe paper phrygian cap
[7550] Look through your crepe paper pie clip
[7551] Play with your crepe paper puzzle
[7552] Leave nothing to the imagination
[7553] Embrace polka
[7574] BCZ: Blood Bath
[7575] BCZ: Dial it up to 11
[7576] BCZ: Sweat Equity
[7577] BCZ: Create Blood Thinner
[7578] BCZ: Prepare Spinal Tapas
[7579] BCZ: Craft a Pheromone Cocktail
BCZ needs thinking on how to add, and if using 22 as 'limit'