Bug All skills with daily limits should appear in dailylimits.txt

fronobulax

fronobulax

Developer
Staff member
From a PR on GitHub

we still report have_skill($skill[whatever]) as true if you can no longer cast the skill. The uncastability is stored in $skill[whatever].dailylimit. Or it should be, some skills aren't wired up correctly.
Click to expand...

This is probably because of skills that are not in dailylimits.txt

Posting here as a reminder.
 
I tried diff'ing modifiers.txt "Conditional Skill" entries against dailylimits.txt (for non-combat) but only added BCZ (and then removed) and the moss medal. Still a fix, but not a complete fix. I leave this here for further investigation:

[7418] Make Sweat-Ade
[7419] Drench Yourself in Sweat
[7420] Sip Some Sweat
[7499] Brandish Moss Medal
[7549] Pull down your crepe paper phrygian cap
[7550] Look through your crepe paper pie clip
[7551] Play with your crepe paper puzzle
[7552] Leave nothing to the imagination
[7553] Embrace polka
[7574] BCZ: Blood Bath
[7575] BCZ: Dial it up to 11
[7576] BCZ: Sweat Equity
[7577] BCZ: Create Blood Thinner
[7578] BCZ: Prepare Spinal Tapas
[7579] BCZ: Craft a Pheromone Cocktail
BCZ needs thinking on how to add, and if using 22 as 'limit'
 
Last edited:
Added a few missing daily limits in r29103 and r29105.

eegee said:
I tried diff'ing modifiers.txt "Conditional Skill" entries against dailylimits.txt (for non-combat) but only added BCZ (and then removed) and the moss medal. Still a fix, but not a complete fix. I leave this here for further investigation:

[7418] Make Sweat-Ade
[7419] Drench Yourself in Sweat
[7420] Sip Some Sweat
[7499] Brandish Moss Medal
[7549] Pull down your crepe paper phrygian cap
[7550] Look through your crepe paper pie clip
[7551] Play with your crepe paper puzzle
[7552] Leave nothing to the imagination
[7553] Embrace polka
[7574] BCZ: Blood Bath
[7575] BCZ: Dial it up to 11
[7576] BCZ: Sweat Equity
[7577] BCZ: Create Blood Thinner
[7578] BCZ: Prepare Spinal Tapas
[7579] BCZ: Craft a Pheromone Cocktail
BCZ needs thinking on how to add, and if using 22 as 'limit'
Click to expand...

In my opinion none of these have daily limits (except for Brandish Moss Medal).

Having looked through the list of skills on the wiki, I believe these are the ones still missing daily limits (or some near-equivalent):
  • Engage ultra-attractive parka mode: It probably doesn't make sense to have a dailylimits.txt entry for this one, but we don't appear to even be tracking which modes have already used it. At the very least, UseSkillRequest.getMaximumCast() support based on the current mode is probably feasible. I don't own a parka, so someone else will need to handle this one.
  • Heavy Rains: Thunder Down Underwear / Rain Coat / Lightning Rod: The wiki is a little unclear and I haven't been able to verify whether these are only castable once per day or if they can be cast multiple times but only grant the item once. I suspect the former, in which case applying a basic dailylimits.txt entry for each should be simple.
 
You must log in or register to reply here.
Back
Top