Page 32 of 32 FirstFirst ... 22 30 31 32
Results 311 to 316 of 316

Thread: Two Crazy Random Summer

  1. #311
    Developer
    Join Date
    Apr 2010
    Posts
    5,134

    Default

    I think it is related to the sender being in 2CRS, as I haven't yet done that path at all, and I get such items sent.

  2. #312
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,500

    Default

    I think it is related to the sender being in 2CRS, as I haven't yet done that path at all, and I get such items sent.
    Originally Posted by Darzil View Post
    I have seen this with fortune teller items. The "sending" character was in TCRS and the "receiving" character has never ascended.
    Well, thank you.
    Originally Posted by Veracity View Post

  3. #313
    Senior Member
    Join Date
    Apr 2018
    Posts
    328

    Default

    There is apparently a thing where mafia finds a bunch of "unrecognized items" in my correspondence kmail tab. Specifically daily affirmations and affirmation cookies that have 2crs names even when I am no longer in 2crs. Things like
    Code:
    Unrecognized item found: non-corrupted cyan bouncing upside-down Daily Affirmation: Adapt to Change Eventually
    Unrecognized item found: non-corrupted cyan bouncing upside-down Daily Affirmation: Adapt to Change Eventually
    Unrecognized item found: non-corrupted cyan bouncing upside-down Daily Affirmation: Adapt to Change Eventually
    Unrecognized item found: non-corrupted cyan bouncing upside-down Daily Affirmation: Adapt to Change Eventually
    Unrecognized item found: dry wet mirror Daily Affirmation: Be a Mind Master
    Unrecognized item found: dry wet mirror Daily Affirmation: Be a Mind Master
    Unrecognized item found: ionized Daily Affirmation: Keep Free Hate in your Heart
    Unrecognized item found: ionized Daily Affirmation: Keep Free Hate in your Heart
    Unrecognized item found: dry wet mirror Daily Affirmation: Be a Mind Master
    Unrecognized item found: dry wet mirror Daily Affirmation: Be a Mind Master
    Unrecognized item found: corrupted tumbling Daily Affirmation: Be Superficially interested
    Unrecognized item found: corrupted tumbling Daily Affirmation: Be Superficially interested
    Unrecognized item found: non-corrupted cyan bouncing upside-down Daily Affirmation: Adapt to Change Eventually
    Unrecognized item found: non-corrupted cyan bouncing upside-down Daily Affirmation: Adapt to Change Eventually
    Unrecognized item found: dry wet mirror Daily Affirmation: Be a Mind Master
    Unrecognized item found: dry wet mirror Daily Affirmation: Be a Mind Master
    Unrecognized item found: non-corrupted cyan bouncing upside-down Daily Affirmation: Adapt to Change Eventually
    Unrecognized item found: non-corrupted cyan bouncing upside-down Daily Affirmation: Adapt to Change Eventually
    Unrecognized item found: boiled green Daily Affirmation: Work For Hours a Week
    Unrecognized item found: boiled green Daily Affirmation: Work For Hours a Week
    Unrecognized item found: corrupted tumbling Daily Affirmation: Be Superficially interested
    Unrecognized item found: corrupted tumbling Daily Affirmation: Be Superficially interested
    Unrecognized item found: small rotten Affirmation Cookie
    Unrecognized item found: ionized Daily Affirmation: Keep Free Hate in your Heart
    Unrecognized item found: small rotten Affirmation Cookie
    Unrecognized item found: ionized Daily Affirmation: Keep Free Hate in your Heart
    It doesn't actually cause any harm, and is only a temporary issue since correspondences are only kept for a limited time before being auto deleted. And you can also manually delete them too (which I just did, and it stopped giving me the above).

    I can't really think of a good mechanical solution to this (at least not one that is not unreasonably tedious).
    Anyone else has an idea for a method that could cleanly handle this? Or is it better to just let it be?
    Originally Posted by taltamir View Post
    That's a bug with KoL, not KoLmafia. As such, I think the correct way to handle this is to get TPTB to fix it.

  4. #314

    Default

    That's a bug with KoL, not KoLmafia. As such, I think the correct way to handle this is to get TPTB to fix it.
    Originally Posted by Saklad5 View Post
    I doubt they would consider it a bug.

  5. #315
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,187

    Default

    I don't think it is necessarily a bug in KoL.

    Here is an item I extracted from a kmail:

    Code:
    <table class="item" style="float: none" rel="id=5899&s=0&q=0&d=0&g=0&t=1&n=1&m=0&p=0&u=u"><tr><td><img src="https://s3.amazonaws.com/images.kingdomofloathing.com/itemimages/analjar_full.gif" alt="jar of psychoses (The Captain of the Gourd)" title="jar of psychoses (The Captain of the Gourd)" class=hand onClick='descitem(710562556)' ></td><td valign=center class=effect>You acquire an item: <b>jar of psychoses (The Captain of the Gourd)</b></td></tr></table>
    Notice that it has a "rel" string and an item descid. We can extract the item id accurately using either of them.

    The issue is that ResultProcessor.processResults creates a list of items using those relstrings, which precisely identify the item by itemid, and then ResultProcessor.processItem looks through the response text picking up each item and matching it against the item from the preprocessed list. It "matches" by comparing item name.

    Not sure why that is necessary.

    If it doesn't match, it falls back to trying to process the item by looking up the item name - which is the TCRS name, in this case - which results in the message you saw.

    I wonder what would happen if we simply didn't check the item name and assumed that we are always processing the items from the list in the same order they came in from the parsed results.

  6. #316
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,187

    Default

    Lets try it out. Revision 19564 will assume that all items parsed by relstring come in the same order as all items parsed by "result text".
    Last edited by Veracity; 09-22-2019 at 10:20 PM.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •