Search results

  1. VeeArr

    New Content Support Heartstone

    The heartstone_middle_letter function was added in r28911, but it does not correctly handle some special characters. As best we can tell, the name of the monster is encoded in UTF-8 and stripped of spaces, and then the middle byte is selected (if there's an odd number of bytes and the middle...
  2. VeeArr

    Headhunter -- a relay script for finding shrunken head targets

    KoLmafia now contains the data needed to determine which characteristics a shrunken head will have based on its target's monster ID and your path. Headhunter is a relay script that allows you to search for monsters that will have certain characteristics when zombified. Whether you're looking for...
  3. VeeArr

    Bug - Fixed Mafia sometimes loses track of liver capacity modifiers when changing equipment

    I've once again come across an issue I've seen mentioned a few times before and had some time to do some investigation. I found that occasionally when changing equipment, mafia would lose track of my Liver Capacity modifiers and would then think I was overdrunk when I wasn't. Curiously, it...
  4. VeeArr

    Bug - Fixed get_related() returns incorrect pulverize data for shadow skin

    The data for mer-kin gutgirdle is also incorrect. > ash get_related($item[mer-kin gutgirdle],"pulverize") Returned: aggregate int [item] twinkly wad => 3000000 I assume this needs to be flagged as coming from the sea or whatever so mafia knows that it pulverizes to salt.
  5. VeeArr

    Bug - Fixed get_related() returns incorrect pulverize data for shadow skin

    Mafia reports that shadow skin pulverizes to wads, but it actually pulverizes to powder. I'm not sure if this is due to other properties being incorrect, or if it's a special case. > ash get_related($item[shadow skin],"pulverize") Returned: aggregate int [item] twinkly wad => 750000 hot wad =>...
  6. VeeArr

    Bug - Fixed Using the replica Deck of Every Card via CLI causes an error state, even if successful

    Yea I think technically if you're out of Ronin in LoL you can pull a non-replica deck. Maybe that's too niche to support, but I think something like this (untested) could maybe cover that case anyway: if (KoLCharacter.inLegacyOfLoathing() &&...
  7. VeeArr

    Bug - Fixed Using the replica Deck of Every Card via CLI causes an error state, even if successful

    I think that fix would just make it break in the case where a user has a non-replica deck but no replica deck, which would probably end up making the problem more common. (edit: No, the "am I in LoL?" check would avoid this being a problem most of the time) A better fix would probably be to...
  8. VeeArr

    Bug - Fixed modifier_eval() failing with some negative numbers

    It looks like it fails on working with expressions with literal values -23963, -23964, or -23968 because of weird shenanigans the expression parser does when converting these specific values to its internal representation. Essentially, they end up getting mapped to the symbols for...
  9. VeeArr

    Bug - Fixed Using the replica Deck of Every Card via CLI causes an error state, even if successful

    The error message from DeckOfEveryCardRequest request doesn't fire (because it does find the replica Deck of Every Card and does successfully use it). However, within InventoryManager.retrieveItem, it prints an error message due to not being able to acquire the (non-replica) Deck of Every Card...
  10. VeeArr

    Bug - Fixed Using the replica Deck of Every Card via CLI causes an error state, even if successful

    A user in Discord reported that their automation was failing because cli_execute("cheat ancestral recall"); was producing an error state despite being successful. Updating the automation to instead use cli_execute("try ; cheat ancestral recall"); succeeds. I haven't run Legacy of Loathing...
  11. VeeArr

    Bug - Fixed Mafia loses track of which equipment can be used for CHEAT CODE skills

    I can confirm that, at least for Powerful Glove's noncombat skills, https://kolmafia.us/threads/r28728-whats-changed-fix-when-overriding-modifiers-persist-non-enchantment-modifiers-by-midgleyc-in-3134-full-changelog-r28727-r28728.31384/ seems to have fixed this issue.
  12. VeeArr

    Bug - Fixed Mafia loses track of which equipment can be used for CHEAT CODE skills

    I suspect this impacts any item which (1) has a DESC_ITEM entry in consequences.txt; and (2) has any noncombat Conditional Skill (Equipped) modifiers listed in modifiers.txt. If so, affected items include (perhaps among others): Cincho de Mayo designer sweatpants Powerful Glove
  13. VeeArr

    Bug - Cannot Reproduce Mafia can't find "sweat out"

    I suspect this is actually the same issue as in https://kolmafia.us/threads/mafia-loses-track-of-which-equipment-can-be-used-for-cheat-code-skills.31151/ Can someone with sweatpants check the following: 1. Unequip the sweatpants and restart mafia completely 2. Verify that skill sweat out works...
  14. VeeArr

    New Content - Implemented October IOTM: Blood cubic zirconia

    I meant to double-check this before running my turns for the day, but forgot. However, I think I noticed that $skill[BCZ: Sweat Bullets].timescast got incremented even if the cast failed (e.g. if used against a boss) and therefore wouldn't increase the cost of a future cast. Probably worth...
  15. VeeArr

    Bug - Fixed Mafia loses track of which equipment can be used for CHEAT CODE skills

    https://github.com/kolmafia/kolmafia/blob/main/src/data/consequences.txt#L88 This seems to imply that the intent is to make sure the Glove's battery level is correctly synced. Re-parsing the enchants seems to happen when it parses stuff out of the description, regardless of whether the data...
  16. VeeArr

    Bug - Fixed Mafia loses track of which equipment can be used for CHEAT CODE skills

    This issue doesn't affect blood cubic zirconium, so I suspect that the reason the glove gets re-parsed on hover is so that it can detect the battery level in the glove and remove the skills if you no longer have enough charge, but the actual parsing got broken at some point?
  17. VeeArr

    Bug - Fixed Mafia loses track of which equipment can be used for CHEAT CODE skills

    Well, I managed to get a debugger hooked up, and I figured out what was causing this. If you hover over the Powerful Glove's icon in your inventory, it attempts to re-parse its enchantments within ConsequenceManager.fireAction(), which in turn uses DebugDatabase.parseItemEnchantments(). The...
  18. VeeArr

    Bug - Fixed Mafia loses track of which equipment can be used for CHEAT CODE skills

    I hadn't seen that one, but yea it does seem like the same issue. Would it be useful to copy my details over to that thread instead, or leave this up?
  19. VeeArr

    Bug - Fixed Mafia loses track of which equipment can be used for CHEAT CODE skills

    This is possibly related to https://kolmafia.us/threads/mafia-cant-find-sweat-out.30600/ but what I've seen so far indicates it's probably a different issue. As with most equipment that grants noncombat skills, if you ask mafia to use one of those skills (e.g. via skill <skillname> in the GCLI...
  20. VeeArr

    Bug - Fixed Duplicate option for "unrefined mountain stream syrup" on HP/MP Usage tab

    Using Mafia r28713, both "unrefined mountain stream syrup" and "unrefined Mountain Stream syrup" are offered as MP restore options on the HP/MP Usage tab. Presumably this portion of the tab is built on the data in MPRestoreItemList, where this option is similarly duplicated...
Back
Top