New Content Support Heartstone

[Ryo_Sangnoir]

We want:

• pref for current in-progress letters
• pref for current attunement modifier, and apply in recalculateAdjustments
• prefs for whether you have the skills unlocked, set by viewing the skills in-combat or on the skillz.php page
• codpiece support: skills, equip codpiece when casting
• function for middle letters / highlight middle letters in relay / Location Details was also requested. Needs to use lastEncounter to get the name right including modifiers unless random_modifiers handles that.
• dailylimits (1 for luck, 5 for otherwise)

Something generic for parsing desc_skill for limits might be nice too.

 

[ckb]

Also:

• Banishmanager for Heartstone: GONE

 

[VeeArr]

The heartstone_middle_letter function was added in r28911, but it does not correctly handle some special characters. As best we can tell, the name of the monster is encoded in UTF-8 and stripped of spaces, and then the middle byte is selected (if there's an odd number of bytes and the middle byte corresponds to a letter).

For example, Legstrong™ stationary bicycle gives an A, because ™ is a three-byte character in UTF-8. heartstone_middle_letter reports that it gives a T (presumably because it counts ™ as one character).

Similarly, Wardröb nightstand has no middle letter (because it actually has length 18), wet Wardröb nightstand gives a B, and haunted Wardröb nightstand has no middle letter (because the middle byte is one of the non-letter bytes that form ö).

It would probably also be good if there were a version of the function that accepted a string so that scripts can test the middle letter of a modified monster name without already being it combat with it.