Search results

  1. K

    Bug - Fixed Ascending set timesRested value to bad value

    Just gonna confirm this is fixed based on my observations.
  2. K

    Bug GCLI: ash math operators outside of parenthesis return an unclear error

    Oh yeah, js doesn't have this issue probably due to how rhino handles operators?
  3. K

    Bug - Fixed Ascending set timesRested value to bad value

    I normally have 15 free rests
  4. K

    Bug - Fixed Ascending set timesRested value to bad value

    Some change between r25765 and r25773, log property changes has started producing bad data for me. I can't tell if the actual properties are not returning correct values or if it's purely a logging issue. For comparison sake, here are excerpts from my logs from yesterday and today. Upon...
  5. K

    Bug GCLI: ash math operators outside of parenthesis return an unclear error

    In the Graphical CLI: > ash (100 - elemental_resistance($element[spooky])) / 100.0 Expected ;, found / () Returned: void > ash ((100 - elemental_resistance($element[spooky])) / 100.0) Returned: 0.46666666666666673 > ash 1+1 Expected ;, found + () Returned: void > ash (1+1) Returned: 2...
  6. K

    Bug encountersUntilNEPChoice set to 6, not 7 after NEP choice

    The counter is reset upon ascending, and I think that is handled correctly, however: The counter should reset upon accepting a quest at the start of Neverending Party. The counter continues from where you left off if you reject the quest. Those might not explain what you're seeing but that is a...
  7. K

    Bug Outfits and foldable items lead to broken state

    When saving and equipping outfits containing foldable items, kolmafia can sometimes end up in a state of miscounting owned items, stating that you own zero of items that you do have or multiples of items that you do not. This leads to bad behavior when running automation involving changing...
  8. K

    Bug lastDesertUnlock improperly set

    It would likely cause a lot of problems for various scripts to stop updating this property, canadv, for instance, relies on it. I posed the question about other paths opening the desert beach in the title because I don't remember at all.
  9. K

    Bug lastDesertUnlock improperly set

    Here's a simple patch that should resolve the issue for Community Service.
  10. K

    Bug lastDesertUnlock improperly set

    After completing Community Service, the desert beach is closed unless you've made a meatcar or any of the other substitutes. Mafia improperly sets the lastDesertUnlock to your current ascension number upon completing this challenge path. Edit: more info below in post #10
  11. K

    Bug - Fixed getWorkshed() (and get_workshed()) fail explosively when you have no workshed

    Can reproduce this in Standard (Quantum Terrarium) with a Mayo Clinic (restricted in standard) installed.
  12. K

    New Content July 2021 IotM - Clan Underground Fireworks Shop

    What is the _fireworksShop property for?
  13. K

    Feature View upcoming Quantum Familiar description popups

    Clicking on the icon for the Quantum Familiar timer should show you the familiar's desc_familiar.php popup from the effects list in the character pane. This would be in line with how clicking on effect icons brings up the desc_effect.php popups. I think it'd help new players out a little bit...
  14. K

    Bug - Fixed JavaScript code cannot call custom ASH function under special circumstances

    I tried it out and was able to reproduce on r20779 using AdoptOpenJDK-16.0.1+9 (build 16.0.1+9).
  15. K

    Bug - Fixed jsref does not match on full camelCase js function names

    The jsref cli command will match full ash function names with snake case instead of camel case which doesn't match what it returns. Examples: > jsref appearanceRates > jsref appearanceRate > jsref appearance { [monster: string]: number } appearanceRates(Location) { [monster: string]: number }...
  16. K

    Bug take_storage always returns true contrary to documentation

    In that case true should indicate a server reply? Is that true even if you don't own a displaycase, or if you don't have access to hangk's or closet?
  17. K

    Bug take_storage always returns true contrary to documentation

    Using this example ash return take_storage($item[hand turkey outline],100000); always returns true. Same with reversing the function arguments. According to the wiki: Based on that this doesn't appear to be working properly. Other take_* functions may behave the same way as this one, I'm not sure.
  18. K

    Feature - Implemented Custom combat disable for fully scripted KoLMafia users

    One more quick thought: Having an API to switch to a temporary disabled CCS could solve things cleanly. So a code solution in js might look something roughly like: const oldCCS = getProperty('customCombatScript'); const ccsName = `${projectName}Temp.ccs` const ccsData = '[ default ]\...
  19. K

    Feature - Implemented Custom combat disable for fully scripted KoLMafia users

    I should have actually listed some of the edge cases that scripts handle currently: Using an item that leads to a fight (BRICKOs, fax, desk bells, Seal Clubber figurines, etc.) Casting a skill that leads to a fight (Evoke Eldritch Horror) Entering a fight via a choice adventure that isn't in a...
  20. K

    Feature - Implemented Custom combat disable for fully scripted KoLMafia users

    There's a growing prevalence of scripts using either KoL's autoattack system, or passing in macro strings or functions to adv1 and runCombat. Personally I'm a big fan of the design to passing in a macro to adv1/runCombat since it lets you keep all combat code in one logical grouping there's no...
Back
Top