Theraze
Active member
As Veracity pointed out, retrieve_item and now available_amount (thanks for that) only check the inventory for worthless items, unlike other items. This is due to InventoryManager's getAccessibleCount checking for worthless items and redirecting it over the HermitRequest, where it specifically checks inventory, instead of using the normal checking code. This does make sense due to it checking 3 items instead of one.
If possible it would be appreciated if these could use some form of the normal getAccessibleCount on the specific items instead of checking inventory directly for more accurate results. Especially when considering that your storage and other places will likely have worthless items available in aftercore, some server hits could be saved by pulling these items (if preferences are so set) instead of using more gum and transferring items back and forth around the closet.
I briefly looked at trying to attach a patch for this, but realized that as it currently stands, HermitRequest.getWorthlessItemCount gets used a LOT in conjunction with the InventoryManager.retrieveWorthlessItems function, and I shouldn't make more work for Veracity by posting a clumsy patch that takes longer to fix than it would for someone who understands the intricacies to do properly in the first place.
HermitRequest.run also uses the same inventory check, but that looks more clear.
If possible it would be appreciated if these could use some form of the normal getAccessibleCount on the specific items instead of checking inventory directly for more accurate results. Especially when considering that your storage and other places will likely have worthless items available in aftercore, some server hits could be saved by pulling these items (if preferences are so set) instead of using more gum and transferring items back and forth around the closet.
I briefly looked at trying to attach a patch for this, but realized that as it currently stands, HermitRequest.getWorthlessItemCount gets used a LOT in conjunction with the InventoryManager.retrieveWorthlessItems function, and I shouldn't make more work for Veracity by posting a clumsy patch that takes longer to fix than it would for someone who understands the intricacies to do properly in the first place.
HermitRequest.run also uses the same inventory check, but that looks more clear.