Bug - Fixed Weirdness in Item Manager if you're full and enqueue stuff from Crimbo Cafe

[wrldwzrd89]

Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
KoLmafia declares world peace.

Silly Mafia, thinking I can eat 220 fullness worth of food. Fortunately, it didn't spend any Meat while doing that.

 

[Veracity]

Works for me in revision 10173:

Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached

Which is to say, I enqueued a single item, it tried to buy it, and it correctly discovered that it couldn't eat it. Or, is there something else you did that didn't work the way you wanted it to? I see that we disallow queuing of regular foods beyond your fullness - but not, apparently, cafe purchases.

Is that the problem? Your bug report is rather unclear...

 

[Bale]

Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.
Purchasing Turnip and Rutabaga Pie at the Crimbo Cafe...
Consumption limit reached.

I'm also using r10173. I think that this bug report is that mafia's mistake is twofold.

First, wrldwzrd89 believes it to be a mistake that KoLmafia will allow you to queue up food well past fullness limit. With normal foods, KoLmafia will simply refuse to allow you to queue up stuff you cannot eat. If I select delicious noodles (3336 possible, 0 current) or fortune cookie (40 meat, 0 current) and click "enqueue" mafia will do nothing. However if I select Turnip and Rutabaga Pie (90 meat) and click "enqueue" mafia will pop up a box asking me how many to enqueue (up to the limits of my purchasing ability, not fullness) and then do it. This is a difference in behavior that seems unintended.

Secondly, wrldwzrd89 believes that after the first time mafia says, "Consumption limit reached" it should stop trying to consume the rest of the queue. That does seem to be a good idea. Of course if it paid attention to consumption limits in the first place, it would never get to this problem. This second issue can be ignored since it is just a symptom of the first.

 

[wrldwzrd89]

I'm also using r10173. I think that this bug report is that mafia's mistake is twofold.

First, wrldwzrd89 believes it to be a mistake that KoLmafia will allow you to queue up food well past fullness limit. With normal foods, KoLmafia will simply refuse to allow you to queue up stuff you cannot eat. If I select delicious noodles (3336 possible, 0 current) or fortune cookie (40 meat, 0 current) and click "enqueue" mafia will do nothing. However if I select Turnip and Rutabaga Pie (90 meat) and click "enqueue" mafia will pop up a box asking me how many to enqueue (up to the limits of my purchasing ability, not fullness) and then do it. This is a difference in behavior that seems unintended.

Secondly, wrldwzrd89 believes that after the first time mafia says, "Consumption limit reached" it should stop trying to consume the rest of the queue. That does seem to be a good idea. Of course if it paid attention to consumption limits in the first place, it would never get to this problem. This second issue can be ignored since it is just a symptom of the first.

Yes, Bale is correct on both points.

 

[Veracity]

Try revision 10174, which looks up food/booze/spleen items by name, rather than by item id. This should work for cafe items (which have negative item ids and thus are not in our database) as well as sushi (which has no item ids at all) to work like regular items.

 

[wrldwzrd89]

Try revision 10174, which looks up food/booze/spleen items by name, rather than by item id. This should work for cafe items (which have negative item ids and thus are not in our database) as well as sushi (which has no item ids at all) to work like regular items.

It's working properly now in r10174. Thanks, Veracity!