Bug - Fixed Vacations not Working

[bumcheekcity]

> ash adventure(1, $location[muscle vacation])

Visit to Beach: Muscle Vacation in progress...

[3593] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

Visit to Beach: Muscle Vacation in progress...

[3593] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

Visit to Beach: Muscle Vacation in progress...
KoLmafia declares world peace.

[3593] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

[3593] Muscle Vacation
Encounter: Man Down at the Hoedown
You gain 56 Fortitude

> ash adventure(1, $location[muscle vacation])

Visit to Beach: Muscle Vacation in progress...

[3593] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

Returned: true

> adv muscle vacation

Visit to Beach: Muscle Vacation in progress...

[3596] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

Visit to Beach: Muscle Vacation in progress...

[3596] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

Visit to Beach: Muscle Vacation in progress...

[3596] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

Visit to Beach: Muscle Vacation in progress...

[3596] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

Visit to Beach: Muscle Vacation in progress...

[3596] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
KoLmafia declares world peace.

Validating adventure sequence...
Requests complete.

Visit to Beach: Muscle Vacation in progress...

[3596] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

Visit to Beach: Muscle Vacation in progress...

[3596] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

Visit to Beach: Muscle Vacation in progress...

[3596] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

Visit to Beach: Muscle Vacation in progress...

[3596] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

Visit to Beach: Muscle Vacation in progress...

[3596] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

Visit to Beach: Muscle Vacation in progress...
KoLmafia declares world peace.

[3596] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

> ash adv1($location[muscle vacation], -1, "")

Visit to Beach: Muscle Vacation in progress...

[3596] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

Returned: true

> ash adv1($location[muscle vacation], -1, "")

Visit to Beach: Muscle Vacation in progress...

[3596] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency

Returned: true

This is on a faxbot multi who CAN adventure at the shore. When I type the cli commands, it just continues to TRY adventuring without doing so. This works perfectly on my main. I'm not overdrunk or anything on the faxbot multi.

 

[bumcheekcity]

Just doing some further testing and:

ash visit_url("shore.php?whichtrip=1")

works fine as expected.

 

[Theraze]

I get this every now and then, but can't really replicate it. It happens generally once every 2-3 ascensions. Manually going on a vacation does seem to fix the issue.

I also had this issue with the old Friar's Gate Ceremony. It would sometimes loop and visit it forever, until I manually visited it in the relay browser. Again, wasn't really able to replicate, so haven't reported. Haven't seen it since the Pandamonium recode...

 

[Veracity]

I have no clue.

> ash adventure(1, $location[muscle vacation])

Visit to Beach: Muscle Vacation in progress...

[309250] Muscle Vacation
Encounter: Bang!
You acquire an item: stick of dynamite

Returned: true

 

[Theraze]

Actually had this happen to me yesterday again. Both adventure and adv1 returned that the visit was successful, but the adventure count didn't increment and the vacation failed to occur...

Since this is an irregular problem, what information can I try to collect when it's happening next time? Turn on debug, run a visit with adv1, and turn it off again?

Edit: Here is the quote from my session logs when it happened. The Encounter is listed as, well...

Visiting Olaf the Janitor
> You have already completed the Bitchin' Meatcar quest.
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
Leaflet inv
Visiting Olaf the Janitor
> You have already completed the Bitchin' Meatcar quest.
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: The Shore, Inc. Travel Agency
[1016] Muscle Vacation
Encounter: Bang!
You acquire an item: stick of dynamite

In working vacations, it has an encounter name. On broken vacations, it goes to "The Shore, Inc. Travel Agency" instead.

 

[Theraze]

Here we are, a half-meg debug log for one adventure where the gCLI output was

> ashq adv1($location[moxie vacation], 1, "")

Visit to Beach: Moxie Vacation in progress...

[1446] Moxie Vacation
Encounter: The Shore, Inc. Travel Agency

Requests complete.

Also, a trimmed log with (hopefully just the stuff from Bale's UR removed) that's significantly easier to read at 12k.

 

[Veracity]

Thanks. The trimmed log shows that taking a vacation requires a password hash, but the failed visit was submitted without a password hash, which apparently makes KoL simply display the Travel Agency page. I'll look at it.

Edit: I know how to reproduce it. The critical little detail you guys didn't share was this:

You invoked adventure() or adv1() to a specific location from character #1, logged out and back into character #2 without closing KoLmafia, and then invoked adventure() or adv1() to that same location.

This has something to do with the first character's password hash being retained in the cached AdventureRequest for a particular $location. I'll experiment more and figure out just what is happening, which will then make the solution clear.

 

[Veracity]

Revision 9271 clears the cached password hashes for all KoLAdventures when you log in a character.

 

[Theraze]

Ah, weird. That does make sense though, since quitting mafia completely does fix the problem, but logging out didn't. Thanks for the awesome detective work, Veracity!