User-submitted PRs

[Veracity]

Apparently, we allow all and sundry to submit a PR.
I have no problem with that; we don't like their code? We don't have to merge it.

But I was surprised when I tried to submit a PR to a new project today and was rejected. I didn't even realize that was was an option.

Permission to Loathing-Associates-Scripting-Society/combo.git denied to Veracity0.

Considering that the owner of that project submitted a PR to KoLmafia - and didn't need special permissions to do it - I was insulted.

So, I'm wondering. What's the difference with THIS project? We accept PRs from any random person, it seems. Should we do that?

 

[ikzann]

Hi Veracity,

Just to double check, did you fork the project first? Since you don't have direct permissions to push to main on that repository, you will have to push to a fork of the project and then file a PR across repositories. That's how contributors to Mafia who don't have commit access work as well.

 

[Veracity]

Ah ha. I cloned it. I'm new at github.