Bug - Fixed "Underwater Familiar" boolean modifier does not respect Bloody Nora

Phillammon

Phillammon

New member
A Robortender that has been fed a Bloody Nora should correctly be considered an underwater familiar for the purposes of the Underwater Familiar boolean modifier, but appears not to be in r20767- easily demonstrated by maximizing sea.
 
gausie

gausie

D̰͕̝͚̤̥̙̐̇̑͗̒e͍͔͎͈͔ͥ̉̔̅́̈l̠̪̜͓̲ͧ̍̈́͛v̻̾ͤe͗̃ͥ̐̊ͬp̔͒ͪ
Staff member
r20772 I think? Worked with some brief testing but it was suspiciously easy to fix so we'll see
 
fewyn

fewyn

Administrator
Staff member
gausie said:
r20772 I think? Worked with some brief testing but it was suspiciously easy to fix so we'll see
Click to expand...

This build looks to have failed in Jenkins.

Code: 
At revision 20772

No changes for svn://svn.code.sf.net/p/kolmafia/code since the previous build
[Kolmafia] $ /var/lib/jenkins/tools/hudson.tasks.Ant_AntInstallation/Apache_Ant_1.10.9/bin/ant daily

Buildfile: /var/lib/jenkins/workspace/Kolmafia/build.xml

clean:

init:
    [mkdir] Created dir: /var/lib/jenkins/workspace/Kolmafia/build
    [mkdir] Created dir: /var/lib/jenkins/workspace/Kolmafia/dist

update:
     [exec] Updating '.':

     [exec] At revision 20772.

svn-version:

gitsvn-version:

version:
     [echo] Current revision: 20772

daily:

svn-version:

gitsvn-version:

version:
     [echo] Current revision: 20772

set.released.false:

init:

svn-version:

gitsvn-version:

version:
     [echo] Current revision: 20772

compile:
    [javac] Compiling 435 source files to /var/lib/jenkins/workspace/Kolmafia/build
    [javac] Ignoring source, target and bootclasspath as release has been set

    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/plaf/linux/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/image/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/multislider/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/plaf/metal/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/plaf/windows/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/plaf/misc/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/painter/effects/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/autocomplete/workarounds/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/graphics/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/plaf/nimbus/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/border/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/combobox/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/plaf/motif/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/renderer/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/util/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/action/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/painter/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/tips/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/error/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/autocomplete/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/color/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/decorator/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/icon/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/multisplitpane/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/geom/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/event/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/plaf/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/treetable/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/plaf/basic/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/plaf/macosx/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/calendar/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/tree/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/auth/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/swingx/table/package-info.class
    [javac] Creating empty /var/lib/jenkins/workspace/Kolmafia/build/org/jdesktop/beans/package-info.class
     [copy] Copying 130 files to /var/lib/jenkins/workspace/Kolmafia/build
     [copy] Copied 9 empty directories to 2 empty directories under /var/lib/jenkins/workspace/Kolmafia/build

svn-version:

gitsvn-version:

version:
     [echo] Current revision: 20772

set.version:
    [javac] Compiling 983 source files to /var/lib/jenkins/workspace/Kolmafia/build
    [javac] Ignoring source, target and bootclasspath as release has been set

    [javac] /var/lib/jenkins/workspace/Kolmafia/src/net/sourceforge/kolmafia/KoLCharacter.java:4324: error: cannot find symbol
    [javac]         return KoLCharacter.getPath().canEat();
    [javac]                                      ^
    [javac]   symbol:   method canEat()
    [javac]   location: class Path
    [javac] /var/lib/jenkins/workspace/Kolmafia/src/net/sourceforge/kolmafia/KoLCharacter.java:4334: error: cannot find symbol
    [javac]         return KoLCharacter.getPath().canDrink();
    [javac]                                      ^
    [javac]   symbol:   method canDrink()
    [javac]   location: class Path

    [javac] /var/lib/jenkins/workspace/Kolmafia/src/net/sourceforge/kolmafia/request/AccountRequest.java:478: error: cannot find symbol
    [javac]                 KoLCharacter.setConsumptionRestriction( AscensionSnapshot.NOPATH );
    [javac]                             ^
    [javac]   symbol:   method setConsumptionRestriction(int)
    [javac]   location: class KoLCharacter

    [javac] /var/lib/jenkins/workspace/Kolmafia/src/net/sourceforge/kolmafia/request/CharSheetRequest.java:333: error: cannot find symbol
    [javac]         KoLCharacter.setConsumptionRestriction(
    [javac]                     ^
    [javac]   symbol:   method setConsumptionRestriction(int)
    [javac]   location: class KoLCharacter

    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 4 errors
    [javac] Compile failed; see the compiler error output for details.

svn-version:

gitsvn-version:

version:
     [echo] Current revision: 20772

unset.properties:

BUILD FAILED
/var/lib/jenkins/workspace/Kolmafia/build.xml:396: The following error occurred while executing this line:
/var/lib/jenkins/workspace/Kolmafia/build.xml:204: Failed to compile KoLmafia source code

Total time: 29 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Finished: FAILURE
 
gausie

gausie

D̰͕̝͚̤̥̙̐̇̑͗̒e͍͔͎͈͔ͥ̉̔̅́̈l̠̪̜͓̲ͧ̍̈́͛v̻̾ͤe͗̃ͥ̐̊ͬp̔͒ͪ
Staff member
Oh crap I committed some unrelated stuff I'd been working on accidentally. I can't fix this until tomorrow sadly
 
H

heeheehee

Developer
Staff member
I reverted via r20773 since nobody beat me to the punch

edit: also reopened the bug while I'm here
 
Last edited:
gausie

gausie

D̰͕̝͚̤̥̙̐̇̑͗̒e͍͔͎͈͔ͥ̉̔̅́̈l̠̪̜͓̲ͧ̍̈́͛v̻̾ͤe͗̃ͥ̐̊ͬp̔͒ͪ
Staff member
Thank you
 
You must log in or register to reply here.
Top