Bug - Fixed Unable to chew new Astral Energy Drink

[Alium]

I want to chew the new(ish) AED to get the Lucky! effect, but it is not working properly. Very well could be I'm using the wrong syntax to specify which AED I want. Crux of the issue is there are two AEDs in the game but have different IDs.

Here is what the CLI outputs


Marked this as a bug since "item_amount" worked properly with item ID. Attached is the debug log it created for the "chew" command. Seems to be a divide by zero issue.

A secondary issue is why did it return true when it failed to chew?

 

[Veracity]

spleenhit.txt

[5140]astral energy drink    8    1    awesome    29-35    0    0    0
[10882]astral energy drink    5    1        0    0    0    0    Lucky!

items.txt:

10882    carton of astral energy drinks    824102367    ast_carton.gif    usable    q    0
10883    astral energy drink    371528474    ast_energy.gif    spleen, usable    q    0

We have the wrong item id in spleenhit.txt

Also in UseItemRequest:

      case SPLEEN:
        return SpleenItemRequest.maximumUses(
            itemId, itemName, ConsumablesDatabase.getSpleenHit(itemName));

We look up the spleen hit by item name, not item id.

 

[Alium]

Thanks for finding the root cause! Made a PR for it

Correct AED Item ID in Spleenhit.txt by Alium58 · Pull Request #1578 · kolmafia/kolmafia

https://kolmafia.us/threads/unable-to-chew-new-astral-energy-drink.28677/

github.com

 

[Alium]

r27229