Bug - Fixed Trading hellseal body parts with Phineas

[philmasterplus]

It seems that KoLmafia does not recognize spending hellseal body parts (brains, sinews, hides, claws, whiskers) when I make items from them.

Specifically, I created ~70-ish seal-brain elixirs, spending all but 1 of my hellseal whiskers. Yet KoLmafia thinks it still has 137 whiskers.

 

[Veracity]

How did you do this? Item Manager, CLI, ASH script, Relay Browser ...
What does your session log say?

 

[philmasterplus]

I was using the relay browser. The relevant portion of the log says:

Visiting a Palm Tree Shelter on the Secret Tropical Island Volcano Lair

Trade 1 hellseal brain, 2 hellseal whisker, 1 hellseal claw
You acquire seal-brain elixir (69)

Perhaps KoLmafia didn't recognize the "make as many as possible" checkbox thingy?

Since I'm power leveling, I'll be able to try reproducing this tomorrow.

 

[Veracity]

It has code to detect the checkbox and deal with it. Apparently the code is wrong.

 

[philmasterplus]

O-kay. I was able to reproduce the bug 2 days in a row. For convenience, I'm attaching the HTML source of the npc store (phineas) in question.

If I have time, I might skim through KoLmafia's code.

Note: I'm using r10958 on Win7 w/ FireFox 12.

 

[philmasterplus]

Aha, got it. Line 131 of PhineasRequest.java:

if ( urlString.indexOf( "makemax=on" ) != -1 )

Should be

if ( urlString.indexOf( "makemax=1" ) != -1 )

Because the HTML uses

<input type=checkbox name=makemax value=1>

 

[lostcalpolydude]

r10960. Not tested.

 

[philmasterplus]

Tested and confirmed--it works! (at least for seal-brain elixirs)