roippi
Developer
http://kol.coldfront.net/thekolwiki/index.php/Thick-Skinned
modifiers.txt needs a tweak, I'm not sure what it is.
modifiers.txt needs a tweak, I'm not sure what it is.
New Content - Implemented thick-skinned (skill) is distinct from thick-skinned (effect)
- Thread starter roippi
- Start date
Captain Kirk
Member
Duplicate modifiers for: thick-skinned
I keep seeing this in black as KolMafia logs in, and since it's been several days
I thought I would post a bug report about it.
I keep seeing this in black as KolMafia logs in, and since it's been several days
I thought I would post a bug report about it.
IronTetsubo
Member
Forgive my likely naive question, but why not just disambiguate the names and move on (see "patch" below)? Not the most ideal, but it will make the warning go away and seems to have little side effect beyond folk wanting to reference the particular modifiers need to know to also disambiguate.
Code:
svn diff src/data/modifiers.txt
Index: src/data/modifiers.txt
===================================================================
--- src/data/modifiers.txt (revision 11164)
+++ src/data/modifiers.txt (working copy)
@@ -3419,7 +3419,7 @@
The Vitus Virus Item Drop: +50, Experience: -5
# There is No Spoon
There Wolf Weapon Damage Percent: +100
-Thick-Skinned Maximum HP: +50
+Thick-Skinned (Skill) Maximum HP: +50
Third Eye Blind Moxie Percent: +50, Mysticality Percent: -50
Three Days Slow Experience (familiar): +3
Ticking Clock Initiative: +30
@@ -3571,7 +3571,7 @@
# Tao of the Terrapin
# Tempuramancy
# The Way of Sauce
-Thick-Skinned Maximum HP: +10, Maximum MP: +10
+Thick-Skinned (Effect) Maximum HP: +10, Maximum MP: +10
Thrift and Grift Meat Drop: +10
Tolerance of the Kitchen Hot Resistance: +2
# Torso AwaregnessIronTetsubo
Member
heh. and as I hit post, I noticed I reversed them... sigh. 
This one's right - the +10 hp/mp is the skill.
This one's right - the +10 hp/mp is the skill.
Code:
svn diff src/data/modifiers.txt
Index: src/data/modifiers.txt
===================================================================
--- src/data/modifiers.txt (revision 11164)
+++ src/data/modifiers.txt (working copy)
@@ -3419,7 +3419,7 @@
The Vitus Virus Item Drop: +50, Experience: -5
# There is No Spoon
There Wolf Weapon Damage Percent: +100
-Thick-Skinned Maximum HP: +50
+Thick-Skinned (Effect) Maximum HP: +50
Third Eye Blind Moxie Percent: +50, Mysticality Percent: -50
Three Days Slow Experience (familiar): +3
Ticking Clock Initiative: +30
@@ -3571,7 +3571,7 @@
# Tao of the Terrapin
# Tempuramancy
# The Way of Sauce
-Thick-Skinned Maximum HP: +10, Maximum MP: +10
+Thick-Skinned (Skill) Maximum HP: +10, Maximum MP: +10
Thrift and Grift Meat Drop: +10
Tolerance of the Kitchen Hot Resistance: +2
# Torso Awaregness
And then when we look at your passive skills and your effects, we have to decide to look up the appropriate modifier and apply it. If I do a "modtrace Maximum HP", I want to see the correct skill/effect (or both) depending on what my current skills and effects grant me.
gcli at login: "Duplicate modifiers for: thick-skinned", fuzzy items
Just a tiny thing that I noticed some versions ago (coloring by me):
I deleted the data files, believing that I might have had old data, and used the newest version (currently r11342). I still get that line at (or rather, even before) login.
While we're at old data, some new stuff is missing:
edit to add:
Apparently, some plurals for happy medium drinks are also missing, e.g. this one:
Just a tiny thing that I noticed some versions ago (coloring by me):
I deleted the data files, believing that I might have had old data, and used the newest version (currently r11342). I still get that line at (or rather, even before) login.
While we're at old data, some new stuff is missing:
(acquired as turtle tamer)
(acquired as accordion thief)
(acquired as a pastamancer)
edit to add:
Apparently, some plurals for happy medium drinks are also missing, e.g. this one:
Last edited:
Merged. Also, use separate threads next time (though the other stuff could go in a McLargeHuge revamp thread, probably).
I guess I can see why you would lump it all together if you thought the thick-skinned issue was just a data file problem.
Edit: All that other stuff added in 11343.
Edit: All that other stuff added in 11343.
Last edited:
Theraze
Active member
The other items were already in posts 6-8 of the McLargeHuge Revamp thread. Good to hear that they've been implemented now, though.
IronTetsubo
Member
Ah, I see you did indeed have to make a change to get modtrace to work. nifty.