In the Store Manager -> Removals tab, I feel like Mafia would benefit from having a "take one" button.
Currently, that panel has a "take out" button, which takes all of the selected items out of your store, and an "autosell" button, which takes all of the selected items out of your store then autosells them. KoL also has the built-in option to "take one", which Mafia currently doesn't use.
Because of the way that panel is implemented, it is much easier to remove the "autosell" button, and have "take all" and "take one" buttons instead.
In my opinion, it has the added benefit of avoiding messy misclicks: if a user wants to remove from the mall and then autosell, it is safer to have him do both actions separately. Maybe the "Additions" panel would benefit from having its autosell button removed too.
Here is a patch that does exactly this. It also adds two ASH functions:
where take_shop( item ) defaults to take_shop( item, true ), so it will remove all of an item from your store, and take_shop( item, false ) removes only one of the item.
The return value is false if you don't have a shop, or if the item isn't in your store, and RuntimeLibrary.continueValue() otherwise (true if there wasn't any error, false otherwise).
I feel like I should also add an equivalent CLI command, but I'm not sure how.
Thoughts?
Currently, that panel has a "take out" button, which takes all of the selected items out of your store, and an "autosell" button, which takes all of the selected items out of your store then autosells them. KoL also has the built-in option to "take one", which Mafia currently doesn't use.
Because of the way that panel is implemented, it is much easier to remove the "autosell" button, and have "take all" and "take one" buttons instead.
In my opinion, it has the added benefit of avoiding messy misclicks: if a user wants to remove from the mall and then autosell, it is safer to have him do both actions separately. Maybe the "Additions" panel would benefit from having its autosell button removed too.
Here is a patch that does exactly this. It also adds two ASH functions:
Code:
boolean take_shop( item it )
boolean take_shop( item it, boolean takeAll )
The return value is false if you don't have a shop, or if the item isn't in your store, and RuntimeLibrary.continueValue() otherwise (true if there wasn't any error, false otherwise).
I feel like I should also add an equivalent CLI command, but I'm not sure how.
Thoughts?