Bug - Fixed Summon Hobo Underling preference not being updated

[lazy_fire]

Using the skill "Summon Hobo Underling" which is limited to 5 casts per day, isn't updating its preference as shown below. I'm using r11596.

> ash print(get_property("_hoboUnderlingSummons"));

0
Returned: void

[14660] Giant's Castle
Encounter: Alphabet Giant
Round 0: lazy_fire wins initiative!
Round 1: Gronald produces a tubular red firecracker labeled M-80, lights the long fuse, and tosses it behind your opponent.
Round 1: lazy_fire casts SUMMON HOBO UNDERLING!
Round 2: alphabet giant takes 26 damage.
Round 2: lazy_fire casts ASK THE HOBO FOR SOMETHING TO EAT!
You acquire an item: delicious noodles
You acquire an item: unidentified jerky
Round 3: alphabet giant takes 30 damage.
Round 3: lazy_fire casts ASK THE HOBO TO TELL YOU A JOKE!
Round 4: alphabet giant takes 28 damage.
Round 4: alphabet giant takes 80 damage.
Round 4: lazy_fire wins the fight!
After Battle: Gronald lights a miniature Catherine wheel and dances in the shower of sparks. How cute!
After Battle: Gronald sits on your fallen opponent's body, blows a smoke ring, and winks at you.
You gain 783 Meat
You acquire an item: original G
You gain 15 Strongness
You gain 16 Wizardliness
You gain 9 Smarm

> ash print(get_property("_hoboUnderlingSummons"));

0
Returned: void

 

[slyz]

Here is the relevant part of FightRequest.updateRoundData():

// The first part is for a hobo underling being summoned
// The second part is from using a dinged-up triangle to summon it
if ( responseText.contains( "A hobo runs up to you" ) &&
	 !responseText.contains( "You give the triangle a vigorous ringing." ) )
{
	Preferences.increment( "_hoboUnderlingSummons", 1 );
}

I don't have the stats to equip the Hodg outfit yet, so could you:

1- start a fight
2- in the Mafia GUI, start a debug log in the Help menu
3- use the Summon Hobo Underling skill
4- stop the debug logging (from the main GUI's Help menu
5- attach the resulting debug log (found in Mafia's folder) to a post here

 

[lazy_fire]

Here is the debug file.

View attachment DEBUG_20121102.txt

 

[slyz]

It looks like the bit of code I quoted was after the part where Mafia checks if the fight is over. As a result, _hoboUnderlingSummons would only be incremented if it happened in the same page load as the end of the fight.

Fixed in r11609.