Bug - Fixed string equality incongruencies

[bordemstirs]

Not sure if this is a bug or not, but it seems rather odd (and potentially full of errors) that "string == string" is case insensitive, where "switch string{case string}" is sensitive, and string indices in aggregates are as well.

 

[Theraze]

Eh, string.equals(string) is probably what you want to use instead...

 

[holatuwol]

Okay, I changed it so that everything is case-insensitive ... but I'm not sure if anyone was relying on case sensitive behavior.

 

[StDoodle]

The big caveat with that change is that not everyone codes in checks using to_lower|upper_case() when validating against a player name. Such scripts are likely to have issues, now.

 

[Winterbay]

Why? If it is now case insensitive all over the place why would that make it more problematic than before?
I mean you can't have two people with different capitalizations of the same name. Or can you?

 

[holatuwol]

Well, if they were using == (which is most common for user names), then it was already case insensitive. It should only be a problem when you start using switches or methods like "contains" for aggregates?