Bug - Fixed Sticky Fingers & Mood

[digitrev]

Running r13566.

I have Sticky Fingers (passive) permed. When auto-filling the maximum set, it adds "When I run low on Sticky Fingers, use 1 bag of Cheat-Os" to my mood. This should not be the case.

 

[Bale]

Could you please explain the steps involved in "auto-filling the maximum set" because I don't know what that means, even though I'm sure it seems obvious to people who do it.

 

[wrldwzrd89]

Could you please explain the steps involved in "auto-filling the maximum set" because I don't know what that means, even though I'm sure it seems obvious to people who do it.

This simply means populating the mood automatically with as many effects as possible that aren't blacklisted (the maximum set). Unfortunately, there's both a passive skill called Sticky Fingers AND an effect called Sticky Fingers. Normally this doesn't cause problems, but it seems to be confusing KoLmafia into thinking the two are related.

 

[Darzil]

r13582.

Mafia thinks that any effect with the same name as a skill is caused by that skill unless told otherwise. Usually this is true. We also have to tell it otherwise when the effect from a skill isn't the same name as the skill.

 

[digitrev]

Could you please explain the steps involved in "auto-filling the maximum set" because I don't know what that means, even though I'm sure it seems obvious to people who do it.

There's an "Auto-fill" option on the Mood Setup sub-menu that allows you to fill it with either the "minimum set (currently active buffs)" or the "maximum set (all available buffs)".

EDIT: It seems this change now causes an NPE. This occurs after I auto-fill the maximum set.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
         KoLmafia v16.2 r13582, Windows 7, Java 1.7.0_45
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Please note: do not post this log in the KoLmafia thread of KoL's
 Gameplay-Discussion forum. If you would like the KoLmafia dev team
 to look at it, please write a bug report at kolmafia.us. Include
 specific information about what you were doing when you made this
 and include this log as an attachment.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Timestamp: Fri Jan 24 07:21:24 EST 2014
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=


Unexpected error, debug log printed.
class java.lang.NullPointerException: null
java.lang.NullPointerException
	at java.lang.String.compareTo(Unknown Source)
	at java.lang.String.compareTo(Unknown Source)
	at java.util.Arrays.binarySearch0(Unknown Source)
	at java.util.Arrays.binarySearch(Unknown Source)
	at net.sourceforge.kolmafia.persistence.SkillDatabase.contains(SkillDatabase.java:1203)
	at net.sourceforge.kolmafia.moods.MoodTrigger.<init>(MoodTrigger.java:148)
	at net.sourceforge.kolmafia.moods.MoodTrigger.constructNode(MoodTrigger.java:499)
	at net.sourceforge.kolmafia.moods.MoodManager.addTrigger(MoodManager.java:266)
	at net.sourceforge.kolmafia.moods.MoodManager.maximalSet(MoodManager.java:431)
	at net.sourceforge.kolmafia.swingui.panel.MoodOptionsPanel$AddTriggerPanel.actionCancelled(MoodOptionsPanel.java:315)
	at net.sourceforge.kolmafia.swingui.panel.GenericPanel$CancelledListener.execute(GenericPanel.java:640)
	at net.sourceforge.kolmafia.swingui.listener.ThreadedListener.run(ThreadedListener.java:239)
	at net.sourceforge.kolmafia.RequestThread$ThreadWrappedRunnable.run(RequestThread.java:400)

 

[Darzil]

Try 13583.

 

[Bale]

This simply means populating the mood automatically with as many effects as possible that aren't blacklisted (the maximum set).

Thanks, but how do I do that? What steps are involved in that action? Maybe digitrev will tell me...

There's an "Auto-fill" option on the Mood Setup sub-menu that allows you to fill it with either the "minimum set (currently active buffs)" or the "maximum set (all available buffs)".

Thank you! I never click that button. I learned something today.