Feature - Implemented Spring cleaning: DebugModifiers

heeheehee

Developer
Staff member
Thanks.

I am nominally worried about the test in that it will break if another source of sporadic <anything> gets added in the future.

I've changed it locally to check "Water Level" (which was added for Heavy Rains, and only has three sources), since I think that's less likely to conflict with new modifiers in the future.
 

fredg1

Member
I tried to find a somewhat rare modifier filter that would give more than one result, since I wanted to include multiple columns in the test (since "sporadic" gave both "sporadic meat" and "sporadic item")
 

heeheehee

Developer
Staff member
I tried to find a somewhat rare modifier filter that would give more than one result, since I wanted to include multiple columns in the test (since "sporadic" gave both "sporadic meat" and "sporadic item")
Acknowledged. But, a good test is one where a breakage is an indicator of newly broken behavior, rather than just a slight change to an underlying assumption. I'd rather not omit test coverage of multiple columns if it means that the test is more robust.
 
Top