Bug - Fixed Something broke: grimstoneMaskPath

[Bale]

The property "grimstoneMaskPath" used to be set by KoLmafia after using a Grimstone Mask and selecting an option from choiceAdventure829.

More recently, I have used the Grimstone Mask and selected option 1. It did open up "The Prince's Ball" zones as expected, but grimstoneMaskPath is not being set.

 

[Darzil]

I'm guessing maybe related to this : http://kolmafia.us/showthread.php?1...ostChoice1-and-postChoice2-and-don-t-bother-l

As it isn't choice.php or fight.php, maybe it's no longer getting passed to choice manager. Would have to see a debug log to be sure.

 

[Veracity]

Seems likely. Could I see a debug log, please?

 

[Bale]

The next time I do that, I'll make sure to get a debug log.

 

[Bale]

> debug on

Encounter: We All Wear Masks

> debug off

> ashq print("grimstoneMaskPath: " + get_property("grimstoneMaskPath"));

grimstoneMaskPath:

Debug Log: http://pastebin.com/KfTnHCrk

 

[Bale]

Debug Log: http://pastebin.com/KfTnHCrk

Did anyone take a look at my debug log to figure out why this got broke?

 

[Veracity]

I forgot about it. Thanks for the nudge.

 

[Veracity]

All right. I remembered to save some turns today.
I have 192 grimstone masks.
That should be enough.

 

[Veracity]

Yeah.

Retrieved: http://www.kingdomofloathing.com/choice.php?pwd&whichchoice=829&option=1
Field: null = [HTTP/1.1 302 Found]
Field: Location = [place.php?whichplace=ioty2014_cindy]

ChoiceManager.postChoice2:

		// If you walked away from the choice, this is not a choice page
		if ( !urlString.startsWith( "choice.php" ) && !urlString.startsWith( "fight.php" ) )
		{
			ChoiceManager.handlingChoice = false;
			return;
		}

 

[Veracity]

Try revision 16896. It worked for me, but I wonder if it weakened the fix that the previous submit was intended to provide...

 

[lostcalpolydude]

Does this same change belong in postChoice1() (assuming it belongs in postChoice2(), since you're not sure about that)?

 

[Veracity]

Seems likely.

The comment talks about "If you walked away from the choice", so, seems reasonable to check the condition only if you know you can walk away from the choice.

 

[Bale]

This grimstone mask setting worked properly to me today.