New Content - Implemented Some plurals

Cool12309 · Nov 30, 2014

I had checked them all but I cleared the CLI (and closed relay chat, which was using an override that placed the CLI there too) to lower lag, which cleared all the plurals, figuring they would be in the session log. They are not there, so those ~3800 requests were for nothing. There were quite a few discrepancies. Anyways, here's the ones that survived:
Wiki is correct:
*** Sloppy Seconds Diner Employee Handbook: KoLmafia plural = "copies of Sloppy Seconds Diner Employee Handbook", Wiki plural = "copies of the Sloppy Seconds Diner Employee Handbo"
*** fishbone kneepads: KoLmafia plural = "fishbone kneepadss", Wiki plural = "pairs of fishbone kneepads"
*** fishbone fins: KoLmafia plural = "fishbone finss", Wiki plural = "pairs of fishbone fins"
*** filet of The Fish: KoLmafia plural = "filet of The Fishs", KoL plural = "filets of The Fish"
*** transmission from planet Xi: KoLmafia plural = "transmission from planet Xis", KoL plural = "transmissions from planet Xi"
*** Xiblaxian xeno-detection goggles: KoLmafia plural = "Xiblaxian xeno-detection goggless", Wiki plural = "pairs of Xiblaxian xeno-detection goggles"
*** dove DNA: KoLmafia plural = "strands of dove DNA", Wiki plural = "strands of Dove DNA"
*** gold tooth: KoLmafia plural = "gold tooths", Wiki plural = "gold teeth"
*** whiskey in a broken glass: KoLmafia plural = "whiskey in a broken glasss", KoL plural = "whiskeys in broken glasses"
*** shot of mescal: KoLmafia plural = "shot of mescals", KoL plural = "shots of mescal"
*** glass of herbal tequila: KoLmafia plural = "glass of herbal tequilas", KoL plural = "glasses of herbal tequila"
*** minin' dynamite: KoLmafia plural = "minin' dynamites", Wiki plural = "sticks of minin' dynamite"
*** Black Bart's Booty: KoLmafia plural = "Booties of Black Bart's", Wiki plural = "Booties of Black Bart"

Mafia is correct:
*** Xiblaxian cache locator simcode: KoLmafia plural = "Xiblaxian cache locator simcodes", Wiki plural = "Xiblaxian cache locator simcode"
*** Agitated Turkey: KoLmafia plural = "bottles of Agitated Turkey", Wiki plural = ""
*** Sasq™ watch: KoLmafia plural = "Sasq™ watches", Wiki plural = ""

Unchecked:
*** Bee's Knees: KoLmafia plural = "Bee's Kneess", Wiki plural = "glasses of the Bee's Knees"
*** Phonus Balonus: KoLmafia plural = "Phonus Balonuss", Wiki plural = "Phonus Balonii"
*** pair of plants: KoLmafia plural = "pairs of plants", Wiki plural = ""
*** Merc Core Field Manual: Sanity Maintenance: KoLmafia plural = "Merc Core Field Manual: Sanity Maintenances", Wiki plural = "Merc Core Field Manuals: Sanity Maintenance"
*** Merc Core Field Manual: Intimidation Techniques: KoLmafia plural = "Merc Core Field Manual: Intimidation Techniquess", Wiki plural = "Merc Core Field Manuals: Intimidation Techniques"

I checked all of the "wiki is correct" messages myself (using the sig image feature for BBB and Sasq watch). I've fixed the wiki for the "mafia is correct". /buy isn't working for the merc core field manuals and I can't find anyone with those items in the "Unchecked" area. Cannon got the speakeasy plurals from the people who run the DCDB.

lostcalpolydude · Nov 30, 2014

Cool12309 said:
I had checked them all but I cleared the CLI (and closed relay chat, which was using an override that placed the CLI there too) to lower lag, which cleared all the plurals, figuring they would be in the session log. They are not there, so those ~3800 requests were for nothing.

There's a file in the data folder with everything.

Veracity · Nov 30, 2014

plurals.txt has things like this:

Code:

14	moxie weed
15	strongness elixir
16	magicalness-in-a-can	magicalnesses-in-a-can
17	spicy noodles	spicy noodles
18	tortoise's blessing
19	asparagus knife	asparagus knives
20	Kentucky-style derby	Kentucky-style derbies
21	sweet ninja sword
22	studded leather boxer shorts	pairs of studded leather boxer shorts
23	chewing gum on a string	chewing gums on strings
24	ten-leaf clover

but the "***" lines are printed via RequestLogger.printLine and go only in to the CLI. Perhaps they should be printed via report.println(), which will put them in to plurals.txt.

Veracity · Dec 24, 2014

Has this been subsumed by your new "checkplurals" thread - which we actually responded to by checking in (some of) them?

Cool12309 · Dec 25, 2014

Veracity said:
Has this been subsumed by your new "checkplurals" thread - which we actually responded to by checking in (some of) them?

I guess a new topic was better because you told me to make a new topic whenever more plurals are found.

Veracity · Dec 26, 2014

You didn't answer my question.

Is there anything in this thread which was NOT fixed (or at least addressed) in the newer thread?

Veracity · Dec 26, 2014

OK, I have heavily whacked our Wiki Lookup, as used by checkplurals. Here are the current results:

Code:

*** black & tan: KoLmafia plural = "blacks & tans", Wiki plural = "blacks & tans"
*** 'WILL WORK FOR BOOZE' sign: KoLmafia plural = "'WILL WORK FOR BOOZE' signs", Wiki plural = "'WILL WORK FOR BOOZE' signs"
*** overpriced "imported" beer: KoLmafia plural = "bottles of overpriced "imported" beer", Wiki plural = "bottles of overpriced "imported" beer"
*** Bone's Farm "wine": KoLmafia plural = "bottles of Bone's Farm "wine"", Wiki plural = "bottles of Bone's Farm "wine""
*** PB&BP: KoLmafia plural = "PB&BPs", Wiki plural = "PB&BPs"
*** Drac & Tan: KoLmafia plural = "Dracs & Tans", Wiki plural = "Dracs & Tans"
*** Dark & Starry: KoLmafia plural = "Dark & Starries", Wiki plural = "Dark & Starries"
*** Pete & Jackie's Dragon Tooth Emporium Catalog: KoLmafia plural = "Pete & Jackie's Dragon Tooth Emporium Catalogs", Wiki plural = "Pete & Jackie's Dragon Tooth Emporium Catalogs"
*** fountain 'soda': KoLmafia plural = "'fountain' sodas", Wiki plural = "'fountain' sodas"
*** bag of W&Ws: KoLmafia plural = "bags of W&Ws", Wiki plural = "bags of W&Ws"
*** Chef Boy, R&D's business card: KoLmafia plural = "Chef Boy, R&D's business cards", Wiki plural = "Chef Boy, R&D's business cards"

These are all cases where we have a plural and were able to successfully find the Wiki page, but, even though we agree with the Wiki, we don't see a match, because of single or double quotes or ampersands.

This would be an issue with the "checkplurals" command.

Code:

*** Cat-Herding Prod has bogus Wiki plural: "I Am A Fish". Ignoring.
*** Annual Ascot has bogus Wiki plural: "I am a fish". Ignoring.
*** Leapin' Trousers has bogus Wiki plural: "I Am A Fish". Ignoring.
*** Solstice Shield has bogus Wiki plural: "I am a fish". Ignoring.

As previously discussed, this is what it is. We are not changing.

Code:

*** Bulky Buddy Box: KoLmafia plural = "Bulky Buddy Boxen", Wiki plural = ""
*** BRICKO octopus: KoLmafia plural = "BRICKO octopodes", Wiki plural = ""

These are most easily dealt with via a "Wiki Names" modifier.

Code:

*** elven limbos gingerbread: KoLmafia plural = "wafers of limbos gingerbread", Wiki plural = ""
*** Vial of jus de larmes: KoLmafia plural = "vials of jus de larmes", Wiki plural = ""
*** Lobster qua Grill: KoLmafia plural = "pieces of Lobster qua Grill", Wiki plural = ""
*** ectoplasm au jus: KoLmafia plural = "bottles of ectoplasm au jus", Wiki plural = ""

These are all things that are easily dealt with by removing italics markup. Yes, we could do it with a Wiki Name, but if KoL introduces another one and the Wiki deals with it the same way, let's just strip out the italics. So I made the Wiki URL deduction do just that.

Code:

*** Steam Card: Jackass Plumber (#2): KoLmafia plural = "Steam Card: Jackass Plumber (#2)s", Wiki plural = "Jackass Plumber (#2)s"
*** Crimbot schematic: Refrigerator Chassis: KoLmafia plural = "Crimbot schematics: Refrigerator Chassis", Wiki plural = ""
*** Crimbot schematic: Swiss Arm: KoLmafia plural = "Crimbot schematics: Swiss Arm", Wiki plural = ""
*** Crimbot schematic: Grease / Regular Gun: KoLmafia plural = "Crimbot schematics: Grease / Regular Gun", Wiki plural = ""
*** Crimbot schematic: Lamp Filler: KoLmafia plural = "Crimbot schematics: Lamp Filler", Wiki plural = ""
*** Crimbot schematic: Hoverjack: KoLmafia plural = "Crimbot schematics: Hoverjack", Wiki plural = ""
*** Crimbot schematic: Rocket Skirt: KoLmafia plural = "Crimbot schematics: Rocket Skirt", Wiki plural = ""
*** Sister Accessory: KoLmafia plural = "Sister Accessories", Wiki plural = ""
*** smart watch: KoLmafia plural = "smart watches", Wiki plural = "smart watchs"
*** augmented-reality shades: KoLmafia plural = "pairs of augmented-reality shades", Wiki plural = ""
*** Crimbot battery: KoLmafia plural = "Crimbot batteries", Wiki plural = "Crimbot batterys"

These look like Wiki bugs.

Code:

*** Sloppy Seconds Diner Employee Handbook: KoLmafia plural = "copies of Sloppy Seconds Diner Employee Handbook", Wiki plural = "copies of the Sloppy Seconds Diner Employee Handbo"

Yeah. So KoL truncates? That sucks.

Code:

*** Merc Core Field Manual: Sanity Maintenance: KoLmafia plural = "Merc Core Field Manual: Sanity Maintenances", Wiki plural = "Merc Core Field Manuals: Sanity Maintenance"
*** Merc Core Field Manual: Intimidation Techniques: KoLmafia plural = "Merc Core Field Manual: Intimidation Techniquess", Wiki plural = "Merc Core Field Manuals: Intimidation Techniques"
*** peppermint tailings: KoLmafia plural = "peppermint tailingss", Wiki plural = "lumps of peppermint tailings"
*** Crimbot ROM: Rapid Prototyping (dirty): KoLmafia plural = "Crimbot ROM: Rapid Prototyping (dirty)s", Wiki plural = "Crimbot ROMs: Rapid Prototyping (dirty)"
*** Crimbot ROM: Mathematical Precision (dirty): KoLmafia plural = "Crimbot ROM: Mathematical Precision (dirty)s", Wiki plural = "Crimbot ROMs: Mathematical Precision (dirty)"
*** Crimbot ROM: Ruthless Efficiency (dirty): KoLmafia plural = "Crimbot ROM: Ruthless Efficiency (dirty)s", Wiki plural = "Crimbot ROMs: Ruthless Efficiency (dirty)"

I believe the Wiki and we should change.

Code:

*** water wings: KoLmafia plural = "sets of water wings", Wiki plural = ""
*** knuckle sandwich: KoLmafia plural = "knuckle sandwiches", Wiki plural = ""
*** industrial strength starch: KoLmafia plural = "boxes of industrial strength starch", Wiki plural = ""

These are all cases where the Wiki has no problem with the item, but KoLmafia thinks the item and an effect or skill is identical because they look the same ignoring capitalization. That's an issue with our Wiki lookup.

Code:

*** sweet tooth: KoLmafia plural = "sweet teeth", Wiki plural = ""

And what the heck is this? It looks like we can't find the Wiki page, but I don't know why.

So...bottom line is that I see the following Wiki bugs:

Code:

*** Steam Card: Jackass Plumber (#2): KoLmafia plural = "Steam Card: Jackass Plumber (#2)s", Wiki plural = "Jackass Plumber (#2)s"
*** Crimbot schematic: Refrigerator Chassis: KoLmafia plural = "Crimbot schematics: Refrigerator Chassis", Wiki plural = ""
*** Crimbot schematic: Swiss Arm: KoLmafia plural = "Crimbot schematics: Swiss Arm", Wiki plural = ""
*** Crimbot schematic: Grease / Regular Gun: KoLmafia plural = "Crimbot schematics: Grease / Regular Gun", Wiki plural = ""
*** Crimbot schematic: Lamp Filler: KoLmafia plural = "Crimbot schematics: Lamp Filler", Wiki plural = ""
*** Crimbot schematic: Hoverjack: KoLmafia plural = "Crimbot schematics: Hoverjack", Wiki plural = ""
*** Crimbot schematic: Rocket Skirt: KoLmafia plural = "Crimbot schematics: Rocket Skirt", Wiki plural = ""
*** Sister Accessory: KoLmafia plural = "Sister Accessories", Wiki plural = ""
*** smart watch: KoLmafia plural = "smart watches", Wiki plural = "smart watchs"
*** augmented-reality shades: KoLmafia plural = "pairs of augmented-reality shades", Wiki plural = ""
*** Crimbot battery: KoLmafia plural = "Crimbot batteries", Wiki plural = "Crimbot batterys"

the following KoLmafia bugs:

Code:

*** Merc Core Field Manual: Sanity Maintenance: KoLmafia plural = "Merc Core Field Manual: Sanity Maintenances", Wiki plural = "Merc Core Field Manuals: Sanity Maintenance"
*** Merc Core Field Manual: Intimidation Techniques: KoLmafia plural = "Merc Core Field Manual: Intimidation Techniquess", Wiki plural = "Merc Core Field Manuals: Intimidation Techniques"
*** peppermint tailings: KoLmafia plural = "peppermint tailingss", Wiki plural = "lumps of peppermint tailings"
*** Crimbot ROM: Rapid Prototyping (dirty): KoLmafia plural = "Crimbot ROM: Rapid Prototyping (dirty)s", Wiki plural = "Crimbot ROMs: Rapid Prototyping (dirty)"
*** Crimbot ROM: Mathematical Precision (dirty): KoLmafia plural = "Crimbot ROM: Mathematical Precision (dirty)s", Wiki plural = "Crimbot ROMs: Mathematical Precision (dirty)"
*** Crimbot ROM: Ruthless Efficiency (dirty): KoLmafia plural = "Crimbot ROM: Ruthless Efficiency (dirty)s", Wiki plural = "Crimbot ROMs: Ruthless Efficiency (dirty)"

The following KoL bugs:

Code:

*** Sloppy Seconds Diner Employee Handbook: KoLmafia plural = "copies of Sloppy Seconds Diner Employee Handbook", Wiki plural = "copies of the Sloppy Seconds Diner Employee Handbo"

and the following issues with KoLmafia's Wiki URL translation code:

Code:

*** water wings: KoLmafia plural = "sets of water wings", Wiki plural = ""
*** knuckle sandwich: KoLmafia plural = "knuckle sandwiches", Wiki plural = ""
*** industrial strength starch: KoLmafia plural = "boxes of industrial strength starch", Wiki plural = ""
*** sweet tooth: KoLmafia plural = "sweet teeth", Wiki plural = ""

Gievn the above, since there are both KoLmafia and Wiki changes required, I guess we are not quite done. But, we are close!

Cool12309 · Dec 26, 2014

Veracity said:

Code:

*** Steam Card: Jackass Plumber (#2): KoLmafia plural = "Steam Card: Jackass Plumber (#2)s", Wiki plural = "Jackass Plumber (#2)s"
*** Crimbot schematic: Refrigerator Chassis: KoLmafia plural = "Crimbot schematics: Refrigerator Chassis", Wiki plural = ""
*** Crimbot schematic: Swiss Arm: KoLmafia plural = "Crimbot schematics: Swiss Arm", Wiki plural = ""
*** Crimbot schematic: Grease / Regular Gun: KoLmafia plural = "Crimbot schematics: Grease / Regular Gun", Wiki plural = ""
*** Crimbot schematic: Lamp Filler: KoLmafia plural = "Crimbot schematics: Lamp Filler", Wiki plural = ""
*** Crimbot schematic: Hoverjack: KoLmafia plural = "Crimbot schematics: Hoverjack", Wiki plural = ""
*** Crimbot schematic: Rocket Skirt: KoLmafia plural = "Crimbot schematics: Rocket Skirt", Wiki plural = ""
*** Sister Accessory: KoLmafia plural = "Sister Accessories", Wiki plural = ""
*** smart watch: KoLmafia plural = "smart watches", Wiki plural = "smart watchs"
*** augmented-reality shades: KoLmafia plural = "pairs of augmented-reality shades", Wiki plural = ""
*** Crimbot battery: KoLmafia plural = "Crimbot batteries", Wiki plural = "Crimbot batterys"

I fixed all of these except for the sister A and all of the schematics. The grease / reg gun has had the plural for 4 days, so I'm assuming that we can add "/" into the list of things that screw up the wiki lookup.

Veracity · Dec 26, 2014

Cool12309 said:
The grease / reg gun has had the plural for 4 days, so I'm assuming that we can add "/" into the list of things that screw up the wiki lookup.

name = 'Crimbot schematic: Grease / Regular Gun' url = 'http://kol.coldfront.net/thekolwiki/index.php/Crimbot_schematic%3A_Grease_%2F_Regular_Gun'

So, we generated the URL: http://kol.coldfront.net/thekolwiki/index.php/Crimbot_schematic%3A_Grease_%2F_Regular_Gun
Note that it UTF-8 encoded the ":" and the "/" characters.

If you go to: http://kol.coldfront.net/thekolwiki/index.php/Crimbot_schematic:_Grease_/_Regular_Gun
it works. In other words, the URL encoding does not seem to be necessary.
If you go to: http://kol.coldfront.net/thekolwiki/index.php/Crimbot_schematic%3A_Grease_/_Regular_Gun
it also works. In other words, URL encoding the ":" is OK.
If you go to: http://kol.coldfront.net/thekolwiki/index.php/Crimbot_schematic%3A_Grease_%2F_Regular_Gun
you get a 404 not found. In other words, the wiki's HTTP server does not understand that UTF-8 character in the URL.

I'd consider that a server bug, but, whatever. The WikiUtilities package will no longer URLEncode, since the Wiki doesn't seem to require it.

Veracity · Dec 26, 2014

Revision 15095 adds the other Wiki plurals that I said I believed. We also had the correct plural for peppermint tailings, but we were missing a tab in the line in items.txt - probably because somebody didn't cut and paste from their session log.

That is fixed too.

I think this is all done now.

lostcalpolydude · Dec 26, 2014

Veracity said:
We also had the correct plural for peppermint tailings, but we were missing a tab in the line in items.txt - probably because somebody didn't cut and paste from their session log.

I wasn't the one who added that item, but I generally find it easier to copy-paste from the CLI and replace spaces with tabs (and then double-check that I got them all) than to open the session log (which means opening up the folder first), scroll to the bottom, then copy-paste. If I'm adding a lot of items I use the session log. I wish CLI output could just be copy-pasted, but I wouldn't know where to start to make that work.

Darzil · Dec 27, 2014

Quite a lot of the recent Crimbo stuff didn't have plurals when released, so they were added from the mafia incorrect plural message, which isn't copy and pastable.

lostcalpolydude · Dec 27, 2014

Darzil said:
Quite a lot of the recent Crimbo stuff didn't have plurals when released, so they were added from the mafia incorrect plural message, which isn't copy and pastable.

The tab was missing before the plural was added, in this case. If you do manually add tabs, when the item isn't tradeable, discardable, quest item or gift item, there are two tabs between use type and autosell value, and that's easy to forget until you screw it up a few times.

Donavin69 · Dec 16, 2015

This seems like an awfully old thread for me to comment on, but this thread specifically says that the Vial of jus de larmes plural is fixed. I'm using a current build and getting the error: "Unrecognized item found: 2 vials of jus de larmes" and it isn't processing kmail with it in...(I haven't tested recently with the lobster qua grill, but I think it was a problem too)

Don

heeheehee · Dec 16, 2015

Can you post some sample HTML? I don't have a multi with several sitting around, and items.txt certainly has the plurals for those two items.

Donavin69 · Dec 16, 2015

From the debug log, if this isn't what you need, let me know...

HTML:

Retrieving server reply
ResponseText has 578 characters.
[{"id":"128694225","type":"normal","fromid":"1998194","azunixtime":"1450276903","message":"<center><table class="item" style="float: none" rel="id=4513&s=0&q=0&d=0&g=1&t=1&n=2&m=0&p=0&u=."><tr><td><img src="http:\/\/images.kingdomofloathing.com\/itemimages\/potion2.gif" alt="Vial of <i>jus de larmes<\/i>" title="Vial of <i>jus de larmes<\/i>" class=hand onClick='descitem(209380924)'><\/td><td valign=center class=effect>You acquire <b>2 vials of <i>jus de larmes<\/i><\/b><\/td><\/tr><\/table><\/center>","fromname":"PacoSr","localtime":"12\/16\/15 09:41:43 AM"}]
Unrecognized item found: 2 vials of <i>jus de larmes
Unrecognized item found: 2 vials of <i>jus de larmes
class net.sourceforge.kolmafia.request.GenericRequest

xKiv · Dec 16, 2015

Where are the escaped forward slashes coming from?
(I wouldn't be surprised if this is "vials of <i>jus de larmes<\/i>" not matching "vials of <i>jus de larmes</i>" ...)

Veracity · Dec 16, 2015

Judging by the JSON, it looks like you are reading kmail via api.php.

xKiv · Dec 16, 2015

Veracity said:
Judging by the JSON, it looks like you are reading kmail via api.php.

So, if there is a bug, it's that mafia is trying to parse item acquisions from kmails, when reading kmail via api.php?
(which, iirc, it shouldn't do for the same reason as when reading kmail via messages.php ?)

lostcalpolydude · Dec 16, 2015

xKiv said:
So, if there is a bug, it's that mafia is trying to parse item acquisions from kmails, when reading kmail via api.php?
(which, iirc, it shouldn't do for the same reason as when reading kmail via messages.php ?)

No, it's just trying to recognize plurals.

New Content - Implemented Some plurals

Member

Developer

Developer

Developer

Member

Developer

Developer

Member

Developer

Developer

Developer

Developer

Developer

Member

Developer

Member

Active member

Developer

Active member

Developer