Bug - Fixed Sidepane no longer shows inebriety limit until refresh

[Veracity]

I assume this is a side effect of moving max inebriety (and fullness) in modifiers?

Log in a character with liver of steel.
Sidepane shows I have 0/14 available ineriety.
Hit the refresh button.
Sidepane shows that I have 0/19 available inebriety.

 

[Ryo_Sangnoir]

Probably something to do with the order things run in. The same problem occurs with the daily deeds for free rests. I guess something needs to prompt it to update after the first recalculateAdjustments of the session.

Or we extract the static initializer from modifiers and move it to the main method. I might try that.

 

[Ryo_Sangnoir]

It looks like it doesn't properly set the skills while initially setting session data (in refreshSessionData in KoLmafia.java). However, this doesn't make any sense to me -- because at the top of the function it calls

GenericRequest request = new CharSheetRequest();
RequestThread.postRequest(request);

which should do exactly that.

I tried adding a recalculateAdjustments after "Session data refreshed." but that's apparently too soon.

 

[Veracity]

Related (written by you on Feb 12):

Bug - Fixed - Compact side pane doesn't include skill bonuses to meat, item, init until first status API request

Bit of an odd one this one. When you log in, the side panel's rendition of your bonuses to meat, item, etc. don't include bonuses received from skills. "modtrace" does show these correctly, as does "ash item_drop_modifier()" and querying the item drop modifier directly. It is fixed after a...

kolmafia.us

 

[Ryo_Sangnoir]

I ran through some tests with ASH: have_skill and item_amount return the right values, but inebriety_limit returns the wrong one -- until the first recalculateAdjustments (e.g. "modtrace liver capacity" will do one -- though that also adds debug behaviour).

I tried adding some "recalculateAdjustments" into the initial setup, but it doesn't change the results. I wonder if something's going subtly wrong with the passive skills cache.

 

[Ryo_Sangnoir]

The compact side pane bug is different (though it looks similar) -- I think the fix for that one just wants a "KoLCharacter.updateStatus()" call after the session is initialized.

This one is about modifiers being computed incorrectly at first login.

 

[heeheehee]

I believe r27647 fixes this.