Bug Roman candelabra damage not tracked

[HippoKing]

Roman candelabra has elemental damage that turns on and off depending on your everything looks effects. At the moment, it appears that none of this is counted by Mafia.

> ash print(equipped_item($slot[off-hand]));

Roman    Candelabra
Returned: void

> effects    everything

4 of 4 AT buffs active.
Everything Looks Green    (13)
Everything Looks Red (19)
Everything Looks Yellow (72)

>    ash numeric_modifier($item[roman candelabra],$modifier[cold damage])

Returned:    0.0

> ash numeric_modifier($item[roman    candelabra],$modifier[sleaze damage])

Returned: 0.0

>    modtrace cold damage

type	source	Cold Damage
Effect	All Glory To the Toad	+2.00	= +2.00
Effect	Icy Glare	+10.00	= +12.00

 

[HippoKing]

OK, they're working correctly for me now. So something funny is happening - to do with which Everything Looks effects I had active?

> effects everything

3 of 4 AT buffs    active.
Everything Looks Red (33)

> ash    foreach e in $elements[] {    print(e.to_string()+"\t"+numeric_modifier($item[roman    candelabra],to_string(e)+" damage"));}

cold 10.0
hot    0.0
sleaze 10.0
spooky 10.0
stench 10.0

 

[HippoKing]

Ma, she's doing it again.

      Casting Spaghetti Breakfast.

You acquire    an item: spaghetti breakfast
Preference _spaghettiBreakfast changed    from false to true
Preference _concoctionDatabaseRefreshes changed from    28 to 29
Preference romanCandelabraYellowCasts changed from 0 to 3
Preference    romanCandelabraBlueCasts changed from 2 to 1
Preference    romanCandelabraPurpleCasts changed from 0 to 2

> effects everything

4 of 4 AT buffs    active.

> ash foreach e in $elements[] {    print(e.to_string()+"\t"+numeric_modifier($item[roman    candelabra],to_string(e)+" damage"));}

cold 0.0
hot    0.0
sleaze 0.0
spooky 0.0
stench 0.0

This is the begining of d2 of an ascension, I have no "everything" effects. They were correctly tracked first, then broke went those preferences updated? I have no idea why they updated. I think I clicked to make Spaghetti Breakfast in the relay browser, nothing else.

 

[Ryo_Sangnoir]

The prefrerences update when the description for the roman candelabra is viewed, which happens when the session is initialized.

Looking at modifiers.txt I can't see anything obviously wrong with the elemental damage part.

 

[HippoKing]

This is fully reproducible by hitting the desc URL after a fresh start of the KoLMafia client.

> ash foreach e in $elements[] {    print(e.to_string()+"\t"+numeric_modifier($item[roman    candelabra],to_string(e)+" damage"));}

cold 10.0
hot    10.0
sleaze 10.0
spooky 10.0
stench 10.0
slime 0.0
supercold    0.0
bad spelling 0.0
shadow 0.0
Returned: void

>    ash string s = visit_url("desc_item.php?whichitem="+to_string($item[roman    candelabra].descid)); print("Got URL");

Preference    romanCandelabraPurpleCasts changed from 2 to 3
Got URL
Returned: void

>    ash foreach e in $elements[] {    print(e.to_string()+"\t"+numeric_modifier($item[roman    candelabra],to_string(e)+" damage"));}

cold 0.0
hot    0.0
sleaze 0.0
spooky 0.0
stench 0.0
slime 0.0
supercold 0.0
bad    spelling 0.0
shadow 0.0
Returned: void

>    effects everything

2 of 4 AT buffs active.

 

[Ryo_Sangnoir]

nice find! I think that's the consequence manager overriding the modifiers, then, and the modifiers aren't parsed correctly because they're roman numerals. So it'll need to be special-cased to not do that.