Bug - Fixed Relay Browser Frame size in Fernswarthy's Basement

[Veracity]

Revision 9822

 

[matt.chugg]

This doesn't work in IE9 (even in compatability mode) can someone check 8 and 7 please? sorry Veracity, I should have tested it more thoroughly, i'll work up a fix.

 

[matt.chugg]

ok this works in ie9 (and compatability) and FF and should work in some way or another for every major browser

### Eclipse Workspace Patch 1.0
#P kolmafia
Index: src/net/sourceforge/kolmafia/webui/BasementDecorator.java
===================================================================
--- src/net/sourceforge/kolmafia/webui/BasementDecorator.java	(revision 9822)
+++ src/net/sourceforge/kolmafia/webui/BasementDecorator.java	(working copy)
@@ -150,8 +150,8 @@
 			buffer.indexOf( "</head>" ), "<script language=\"Javascript\" src=\"/basement.js\"></script></head>" );
 
 		StringBuffer changes = new StringBuffer();
-		changes.append( "<table>" );
-		changes.append( "<tr><td><select id=\"gear\" style=\"width: 100%;\"><option value=\"none\">- change your equipment -</option>" );
+		changes.append( "<table id=\"basementhelper\" style=\"width:100%;\">" );
+		changes.append( "<tr><td style=\"width:90%;\"><select id=\"gear\" style=\"width: 100%;\"><option value=\"none\">- change your equipment -</option>" );
 
 		// Add outfits. Skip the "No Change" entry at index 0.
 
@@ -208,7 +208,7 @@
 			changes.append( "</option>" );
 		}
 
-		changes.append( "</select></td><td> </td><td valign=top align=left><input type=\"button\" value=\"exec\" onClick=\"changeBasementGear();\"></td></tr>" );
+		changes.append( "</select></td><td> </td><td style=\"vertical-align:top; text-align:left;\"><input type=\"button\" value=\"exec\" onClick=\"changeBasementGear();\"></td></tr>" );
 
 		// Add effects
 
@@ -222,7 +222,7 @@
 			String modifierName = Modifiers.getModifierName( BasementRequest.getActualStatNeeded() );
 			modifierName = StringUtilities.globalStringDelete( modifierName, "Maximum " ).toLowerCase();
 
-			changes.append( "<tr><td><select onchange=\"" );
+			changes.append( "<tr><td style=\"width:90%;\"><select onchange=\"" );
 			changes.append( computeFunction );
 			changes.append( "\" id=\"potion\" style=\"width: 100%;\" multiple size=5>" );
 
@@ -256,7 +256,7 @@
 				BasementDecorator.appendBasementEffect( changes, booster );
 			}
 
-			changes.append( "</select></td><td> </td><td valign=top align=left>" );
+			changes.append( "</select></td><td> </td><td style=\"vertical-align:top; text-align:left;\">" );
 			changes.append( "<input type=\"button\" value=\"exec\" onClick=\"changeBasementEffects();\">" );
 			changes.append( "<br/><br/><font size=-1><nobr id=\"changevalue\">" );
 			changes.append( BasementRequest.getBasementTestCurrent() );

I've only done the minimum to make it work (by setting the table width so that the select then has a percentage width of something) i've also give the table an id so that anyone can override the table layout in the css if they so wish.