r26661 - Attempt to permanently meet otherwise stochastic coverage changes by g

[Github Bot]

What's Changed​

• Attempt to permanently meet otherwise stochastic coverage changes by @gausie in #987

Full Changelog: r26660...r26661

View on Github

 

[fronobulax]

The following occurs in 26661 but not 26660.

> checkconcoctions

Failed comparing (quasi symmetry) [2742] steel lasagna and [2742] steel lasagna
Failed comparing (quasi symmetry) [2743] steel margarita and [2743] steel margarita
Failed comparing (quasi symmetry) [2744] steel-scented air freshener and [2744] steel-scented air freshener
Concoctions checked.

checkconcoctions verifies the contract for Concoction.compareTo(). The failure message means

sgn(x.compareTo(y)) == -sgn(y.compareTo(x)

failed.

I have not gotten a chance to look at the new code to see why and that chance might not come immediately so I'm posting.

@gausie

 

[heeheehee]

Yeah, as far as I can tell, this misses the case where they're the same steel organ (and thus have the same sortOrder).

   if (this.steelOrgan) {
      // No need to see if they are both steel organs as they have different sort orders
      // and are thus differentiated above.
      return -1;
    }