Github Bot
Poster of Commits
What's Changed
- Enable icon images for windows by @libraryaddict in #775
Full Changelog: r26413...r26414
View on Github
r26414 - Enable icon images for windows by @libraryaddict
- Thread starter Github Bot
- Start date
Full Changelog: r26413...r26414
View on Github
This PR changes the image only for Windows, as (seemingly) intended.
Untested.
github.com
Untested.
keep limeglass icon if not windows. Fix a comment by Veracity0 · Pull Request #777 · kolmafia/kolmafia
A recent PR "Enabled icon images for Windows". Unfortunately, it changed the Dock icon image on Macs from the friendly and familiar limeglass to a black & white sword and martini guy. This PR uses ...
github.com
Sorry, I delayed pushing it in hopes someone on another OS would comment.
FWIW I have never seen the lime glass icon on Windows. Before this I always saw the Java Cup icon. But, yeah, it wasn't expected to change anything on another OS.
FWIW I have never seen the lime glass icon on Windows. Before this I always saw the Java Cup icon. But, yeah, it wasn't expected to change anything on another OS.
A github bug makes the "macos-latest, 11" test fail.
Code:
Publish coverage report
1 Run codecov/codecov-action@v2
10 ==> macos OS detected
11 https://uploader.codecov.io/latest/macos/codecov.SHA256SUM
12 Error: Codecov: Error validating uploader: Misformed armored textAnd, as you have noticed, I managed to restart the test and it worked to completion.