Bug - Fixed Pref photocopyMonster Not Updating Upon Receiving Fax

[Alium]

Today garbo and other scripts had issues faxing a monster. I believe root cause is pref photocopyMonster was not being updated by mafia when receiving a fax. It does update when I manually view the photocopied monster item.

r26778 does not update the pref upon fax receipt
r26777does update the pref upon fax receipt

 

[gausie]

This could end up being wrong of course but looking at the code change introduced in r26778 it seems impossible to have introduced this bug.

Can you provide a debug log of you receiving a fax?

 

[gausie]

Unless it's something to do with the action pattern change? That debug log is going to be useful - I bet this is it actually.

 

[gausie]

@Veracity yeah it turns out we were relying on the action pattern to catch preactions in other places (particularly in ClanLoungeRequest) and those have now broken. I started on a fix but it seems like it might be a big bit of work - how do you want to proceed?

 

[gausie]

https://github.com/kolmafia/kolmafia/pull/1109 is my WIP

 

[Veracity]

Perhaps we need an ONLY_ACTION_PATTERN and use it where needed.
Perhaps we need to modify the places that call preactions.

There are several options.

I’ll look at your PR after breakfast; it is 7 AM here.

 

[Veracity]

gausie fixed this.

 

[Alium]

Thanks for the quick work!

 

[phreddrickk]

I believe this is also related to the action-preaction issue: mafia does not appear to be updating asdon fuel quantities upon running an `asdonmartin drive X`. Or at least it's not taking a failure and turning that into a new fuel amount.

I wish I could provide more details, but I can't at present. I'll investigate it more later if anyone needs any additional information.

update

> debug on

> asdonmartin fuel 11 pie man

Created an empty checkpoint.
Searching for "pie man was not meant to eat"...
Search complete.
Purchasing pie man was not meant to eat (11 @ 1,239 = 13,629) from #1960201...
Purchases complete.

Converting 11 pies men were not meant to collectively eat into Fuel

> js getFuel()

Returned: 1558

> asdonmartin drive observantly

You acquire an effect: Driving Observantly (30)

> js getFuel()

Returned: 1558

 

[gausie]

Fixed!

 

[reverkiller]

Fixed!

I am still having issues with Asdon on KoLmafia-26785.jar (which, as far as I can tell, is the most recent build)

 

[gausie]

I am still having issues with Asdon on KoLmafia-26785.jar (which, as far as I can tell, is the most recent build)

What issues are you having?

 

[gausie]

Ok this and a few other issues I have seen mentioned are handled here: https://github.com/kolmafia/kolmafia/pull/1115