Bug - Fixed Performance issues
- Thread starter Darzil
- Start date
Bale
Minion
I tried relocating the images to /data and it did not work. In retrospect I suppose I should have expected that. Is there some trick to using images in the data directory or is it simply impossible?
OK, that worked. Thanks.
I started up Chrome and navigated to various pages - terrarium, inventory. I did notice some broken links - and when I looked at my trace log, I saw that we had fetched the files and the browser later asked for those same files with "If-Modified-Since". KoLmafia send bak "Not Modified", on the assumption that if we had it cached, the browser must have had the file. Apparently not.
I didn't have a full debug log, so I don't know what Modified-Since date it was asking for.
Revision 12641 actually compares the "If-Modified-Since" date to the the lastModified date of the file. If the file is newer, it sends the file (again). Otherwise, it says Not Modified.
I was unable to reproduce the problem after doing this. Actually, I was unable to reproduce the problem BEFORE doing this; only the first try actually had any broken images. So, I don't know if this fixes your problem, but it's the only suspect behavior I was able to observe.
I started up Chrome and navigated to various pages - terrarium, inventory. I did notice some broken links - and when I looked at my trace log, I saw that we had fetched the files and the browser later asked for those same files with "If-Modified-Since". KoLmafia send bak "Not Modified", on the assumption that if we had it cached, the browser must have had the file. Apparently not.
I didn't have a full debug log, so I don't know what Modified-Since date it was asking for.
Revision 12641 actually compares the "If-Modified-Since" date to the the lastModified date of the file. If the file is newer, it sends the file (again). Otherwise, it says Not Modified.
I was unable to reproduce the problem after doing this. Actually, I was unable to reproduce the problem BEFORE doing this; only the first try actually had any broken images. So, I don't know if this fixes your problem, but it's the only suspect behavior I was able to observe.
Images are cached only in /images or a subdirectory.
It's fine with me if there is one designated directory for relay overrides to store images in which we will not look at on a "cache clear", however that is done. images/relay seems fine.
Tussosedan
New member
Are you using Java 6 or 7?
I had a similar issue, and moving back to Java 6 seems to have fixed it for me.
I'm using 7. I might try moving back to 6 for a day to see if the issue goes away. If it did I'd then know I was looking for a Java issue rather than a Kolmafia one.
Fluxxdog
Active member
I'm looking at your code before I updated for the day:
Code:
string imagePath = "/images/chit/";Bale
Minion
I agree, but if you look up a couple of posts to #44 you'll see that mafia can only use images if they are in the /images directory.
Fluxxdog
Active member
Ah, I thought she was just talking about cached images, not all images. Odd. If a call is made for anything without an http(s):// why should it treat it like it was cached? It sounds like anything that looks for "/images/whatever/" will automatically look in "http://images.kingdomofloathing.com/whatever/" if caching is disabled. Am I right in my interpretation?
No. If a page asks for something in /images, KoLmafia will always look there, whether or not caching is enabled. It might copy the image from one of it's built-in images - the green porko arrow, the up arrow in the charpane, whatever - or, it might go to images.kingdomofloathing.com to fetch it. Or it might already be there from a previous load.
The only thing turning on or off caching does is determine if KoLmafia munges links in pages returned by KoL from http://images.kingdomofloathing.com/whatever to /images/whatever. It has no effect on images that are alread in /images.
It is safe to clear everything in /images, since if KoLmafia is asked to serve something there, it will copy it from it's built-in images if it is not there - except for custom images added by scripts, like chit. I believe that /images is the only built-in os-independant way for a relay script to put in a link to a local file into a page.
I like /images/relayimages/whatever as a "safe" directory of relay script images that KoLmafia will not clear by itself, when I add "cache clear" or whatever.
Captain Kirk
Member
So in version 12644 in Chrome I was playing with "Empty the Cache" since the beginning of time. It seems that every time I did this, and then reloaded a page, I would see broken images.
(using the "Cache KoL images to conserve bandwidth") preference. So far the only way to fix this seems to be to both empty the cache in chrome again, quit mafia, empty the image directory
(of everything except "chit") and then restart mafia and the relay browser. Even some of the chit images where broken after I cleared the cache in Chrome (using this test).
Edit: well I was able to quit kolmafia and restart, and a lot of the images were fixed. I also noticed a "delay" where if I loaded a page, some images would be broken, and
then if I reloaded, the images would be fixed.
Edit Edit: I also noticed that instead of wiping out images in the image directory, if you instead touch each file (updating the timestamp). In macosx you'd have
to do this in the console:
find . -name \* -exec touch {} \;
Once the timestamps are updated, sometimes that fixes broken images.
Also, sometimes if you open a broken image in a new tab you can see it.
(using the "Cache KoL images to conserve bandwidth") preference. So far the only way to fix this seems to be to both empty the cache in chrome again, quit mafia, empty the image directory
(of everything except "chit") and then restart mafia and the relay browser. Even some of the chit images where broken after I cleared the cache in Chrome (using this test).
Edit: well I was able to quit kolmafia and restart, and a lot of the images were fixed. I also noticed a "delay" where if I loaded a page, some images would be broken, and
then if I reloaded, the images would be fixed.
Edit Edit: I also noticed that instead of wiping out images in the image directory, if you instead touch each file (updating the timestamp). In macosx you'd have
to do this in the console:
find . -name \* -exec touch {} \;
Once the timestamps are updated, sometimes that fixes broken images.
Also, sometimes if you open a broken image in a new tab you can see it.
Last edited:
Bad idea. The "lastModified" dates are explicitly and intentionally set to the dates that KoL sends us.
In any case, I suggest that you get revision 12646, actually clear your image cache, and try again. That revision will not erroneously return "Not Modified" to requests that weren't asked for "If-Modified-Since". I forgot to initialize an instance variable and when the instance was reused, it had the previous request's value...
Captain Kirk
Member
Ok yes, 12646 seems to fix all the bugs I was seeing. Great! I like the idea of caching images.
Bale
Minion
Done.
Fluxxdog
Active member
Just for record, with equipment in every slot, I did this:
Logs attached. When I hit enter after the outfit command, it took about 5 seconds before the CLI went back to green. Normally the CLI just goes grey for a spilt second. The trace log show response and return times are from .1 to .2 seconds. Since no images are called, maybe someone can see something else?
Code:
> debug on
> outfit birthday suit
Taking off everything...
Everything removed.
> debug off
> debug trace off