New Content Path: Blue vs. Red

VeeArr

Member
Now that most things are working correctly for the new path, I wanted to make a place where we can track the things that are still not working as expected in the Blue vs. Red path (mostly things not getting tracked correctly in the NCs, presumably). If anyone notices more things, post them here so they're all collected in one place; I'll try to keep this list up-to-date.

I'm aware of the following:
  • Bug: Friendly NCs incorrectly set the lastNoncombat### preference and mess up forcenoncombat tracking.
  • Bug: Friendly NCs incorrectly get added to a location's noncombat queue, rather than the corresponding monster being added to the location's combat queue.
  • Bug: Using a pocket wish (post-Ronin) to summon a friendly monster does not increment _genieFightsUsed
  • Nice to have: Relay warnings when doing the wrong side of the island war
  • Nice to have: Monster data about whether a monster is red team, blue team, or enemy team.

Already implemented:
  • Bug: Defiled Cyrpt progress is not advanced during friendly NCs. (fixed r29181)
 
Last edited:
Currently looking into adding team affiliation into the monster data, but I'm looking for some feedback on how to best accomplish it. I've considered a few options:

1. Have an entirely separate data file with mappings for monster ID to team affiliation, and a specialized ASH method for getting the data (similar to the implementation of cup of 13s item tiers).
2. Have several team-based tokens in the monster attributes (something like BVR_RED, BVR_BLUE, and BVR_ENEMY), similar to monster subtypes.
3. Have a specialized team-based token in the monster attributes (something like BvR: red, BvR: blue, and BvR: enemy), similar to monster phyla. This could be backed by either a new enum or just a String.
4. This is too much of a headache to bother tracking, just leave the data out altogether.

My inclination was #3 backed by an enum. Any thoughts?
 
My inclination is #1, similar to monster parts. Though, given there's only three options, #2 or #3 is also viable.

Probably I feel like separating it just because it's only relevant in one specific case: you're in BvR and want to look up the team of a monster you might be fighting (and we're unlikely to update new monsters after the path is no longer standard). But then, adventures.txt includes the Heavy Rains water level inline. So probably #3.
 
Back
Top