Feature - Implemented Patch - All-Year Sucker Daily Deed

[JimblyCakes]

Attached is a patch that adds the new Crimbo item All-Year Sucker to the Daily Deeds. Any comments/suggestions?

View attachment all-year-sucker.diff

 

[slyz]

I'm not sure we need to modify the Daily Deeds, since a custom deed could be easily added to account for the All-Year Sucker. Adding a _allYearSuckerUsed preference to track usage should be done, thought. Same goes for the heart of dark chocolate.

EDIT: Marking this as Feature Request (the "implemented" bit is only used when the feature actually makes it in the code).

 

[slyz]

r10163 adds preferences to track usage of both items. If someone wants to add either one to their Daily Deed panel, they can add a custom item deed.

 

[JimblyCakes]

Thanks for adding the preference.

If this were also a Daily Deed by default, it would reach more users, since it would just up automatically if applicable. The custom daily deed feature is very flexible, but does require extra setup from users and that they know already what they want as a deed. Just my 2c as to why it would be nice as a built-in daily deed.

 

[slyz]

If someone comes here to ask for a built-in daily deed button for the sucker, someone will surely explain how to use the custom deeds. Information is power! (and less work for the devs )