Bug - Fixed Off By One Problem in Contact List

[FrankNBeans]

Checked today's build (r11302) to verify and bug still exists.

Selecting any entry from my contact list (via People->Contact List) opens a chat window to the entry immediately before the entry selected.

E.g.

Contact List:

alpha
beta
gamma
delta

Select beta, chat window to alpha opens.


environment:
[sbruno@powernoodle /usr/home/sbruno]$ java -version
openjdk version "1.6.0"
OpenJDK Runtime Environment (build 1.6.0-b24)
OpenJDK 64-Bit Server VM (build 20.0-b12, mixed mode)

FreeBSD powernoodle 9.0-STABLE FreeBSD 9.0-STABLE #4 r238348M: Tue Jul 10 09:21:52 PDT 2012 sbruno@powernoodle:/usr/home/sbruno/bsd/9/sys/amd64/compile/GENERIC amd64

 

[Catch-22]

Patch fixes issue and introduces a new feature.

With this patch if you select multiple contacts and double click, it will open a chat tab to all the selected contacts (not just the one you double click).

 

[FrankNBeans]

I don't have a build environment setup to test this patch yet, but it looks right to me.

 

[Catch-22]

Oops, the patch I posted worked just fine (I had tested it) but in the original one I posted I accidentally left a line of old code there (int index = list.locationToIndex( e.getPoint() );) which was being executed for no reason. Newly attached patch removes that line

 

[roippi]

Extant code works fine for me, but patch uses more robust code (getSelectedValues vs locationToIndex), so why not. r11323

 

[Catch-22]

I always appreciate being able to clean up my repository Thanks roippi. Good spotting on the other unused line, too.