Bug - Fixed Native Mafia Chat not rainbow for Holiday Fun!

Well, System Messages (like Mod Messages and Mod Warnings) are red and Events are green. I made the intentional decision to show System Messages in your current channel (which may not be the tab you are sitting on) and also in Events, but not in all of the tabs you have open. In that respect, it is now like KoL's "modern" (tabbed) chat.

I like that, but do I understand that you want them to go to all open tabs, as if they were an Event, if you have broadcastEvents set? Since I have broadcastEvents set to false, I would still retain my preferred behavior.

I'd like some feedback from other users of the chat GUI. I think we are close to being able to make everybody happy.
 
OK, revision 14966 does this:

If you have broadcastEvents set to true, a System Message is posted to all tabs (in red) even though it is not an "event" per se.
If that setting is false, it is put only in the Events tab, ditto.

I tested this with my saved System Message, but since I was out of the house from 5 hours before rollover until an hour afterwards, I couldn't actually test it live.

I expect it will work. See what you think at rollover tonight. If all is cool, I'm going to mark this fixed - and maybe spin a new release, since the new Skills Menu and Challenge Path seem to be supported enough.
 
Hrm - r14966 displays a green /trade Mod Announcements in all open channels and the events tab.
Is that really how it's supposed to work?

I truly lost track of what's meant to be displayed in what way and where. :confused:
 

Attachments

  • modannoucement.jpg
    modannoucement.jpg
    85.2 KB · Views: 50
I was just looking at this myself; I had never seen a Mod Announcement before, but now I have one to play with.

Code: 
<font color=green><font color=green>[trade]</font> <b><a target=mainpane href="showplayer.php?who=996875"><font color=green>Mod Announcement</font></b></a>: Welcome to /trade! Please allow at least 5 minutes between your ads in here. Thank ye kindly.<br></font><!--lastseen:1390739578-->

And, for what it's worth, here is what mchat got for that same announcement:

Code: 
{"msgs":[{"msg":"Welcome to \/trade! Please allow at least 5 minutes between your ads in here. Thank ye kindly.","type":"public","mid":"1390739577","who":{"name":"Mod Announcement","id":"996875","color":""},"format":"4","channel":"trade","channelcolor":"green","time":"1416592140"}],"last":"1390739578","delay":3000}
type = public, format = 4. Our code for processing mchat messages from the relay browser assumed that Mod messages would come in as type = "system". Wrong. mchat.js also tells me that Mod Warnings are type = public, format = 3.

I am trying to capture one to verify, but there is clearly more work to do on this...
 
Revision 14967 fixes Mod Announcement and formats them in green in the appropriate channel, not as Events. It should also handle Mod Warnings and Mod Announcements that come in from mchat in the browser.
 
You must log in or register to reply here.
Back
Top