Bug - Fixed my_class() returning void for Actually Ed the Undying

[fewyn]

> ash my_path()

Returned: Actually Ed    the Undying

> ash my_class()

Returned:    void

Last time this worked looks to be back in 25792 where it returned.

> ash my_class()

Returned: Ed
primestat    => Mysticality

 

[heeheehee]

@gausie I haven't looked at the new class handling very closely, I think this might be up your alley?

 

[Irrat]

This would be caused by https://github.com/kolmafia/kolmafia/commit/c82d28d5ee5969ecb970ede7f8db2a7b0167c852

The class is reported by KOL as "Ed the Undying" however Mafia expects "Ed"

public static final void setAscensionClass(final String className) {
  setAscensionClass(AscensionClass.nameToClass(className));
}

The reason this works

ash visit_url("api.php?what=status&for=status")

Is because it's setting it using the class ID.

So in interest of maintaining backwards compatibility, the best option is likely to add a class alias. I'm not sure it should ever have been called "Ed", but "fixing" that would break quite a few scripts.

As for that commit, I think I might've misunderstood it. Without actually checking, best guess is that it previously loaded using the class ID. Not the name.

 

[fewyn]

So I'm no expert but I did partially fix this in a local build but it breaks basically all compatibility with existing scripts. (They are all expecting Ed when the api returns Ed the Undying which mafia now also returns)

GitHub - fewyn/kolmafia at actually-ed

KoLmafia is a cross-platform desktop tool which interfaces with the online adventure game, Kingdom of Loathing 🍸 - GitHub - fewyn/kolmafia at actually-ed

github.com

I really don't know how to write in Java I usually just klutz my way around to fix things so I'd have no clue how to go around adding an alias.

 

[fewyn]

I added a PR at least for the first part of this fix. https://github.com/kolmafia/kolmafia/pull/195

 

[gausie]

Missed my @ here, sorry. I'll take a look at your PR today @fewyn