1) There are disabled Commerce Ghost tests because we lack HTML that captures what we are testing for. Anyone with a ghost want to help?
2) There are three disabled tests that access the KoL Wiki. Should we try and capture the wiki data and refactor the code so that some of it can be exercised without using a network? Maybe we just delete the tests instead, acknowledging we have learned much about testing in several months and they aren't as useful as hoped?
3) One of those tests fails anyway because the Wiki returns malformed JSON. (So the corresponding mafia code will not do anything useful). Does anybody have contacts at Coldfront who might be willing and able to fix it? The Wiki page displays just fine. It is the JSON of that page as returned from an api that needs attention.
4) There are several debug commands that will load HTML from a local file and then use KoLmafia to parse it. The use case is programmers trying to tweak their code, new content detection and validation of data files. Is it worthwhile to collect some of this "test html" and then use it in a test that just loaded it and ran the appropriate "debug" command?
@gausie @MCroft @Ryo_Sangnoir ?
2) There are three disabled tests that access the KoL Wiki. Should we try and capture the wiki data and refactor the code so that some of it can be exercised without using a network? Maybe we just delete the tests instead, acknowledging we have learned much about testing in several months and they aren't as useful as hoped?
3) One of those tests fails anyway because the Wiki returns malformed JSON. (So the corresponding mafia code will not do anything useful). Does anybody have contacts at Coldfront who might be willing and able to fix it? The Wiki page displays just fine. It is the JSON of that page as returned from an api that needs attention.
4) There are several debug commands that will load HTML from a local file and then use KoLmafia to parse it. The use case is programmers trying to tweak their code, new content detection and validation of data files. Is it worthwhile to collect some of this "test html" and then use it in a test that just loaded it and ran the appropriate "debug" command?
@gausie @MCroft @Ryo_Sangnoir ?