Bug - Fixed Ms. Accessory

bordemstirs

New member
So, not really sure why, but for some reason the maximizer decided that a Ms. Accessory was better than a Mr. Accessory. I wasn't paying that close attention (and they look pretty similar) so I just trusted mafia to do its thing.
And it spent my Mr. Accessory on a Ms. Accessory.


If we get get it hardcoded to like.. never do this, that would be awesome.
 

Catch-22

New member
If we get get it hardcoded to like.. never do this, that would be awesome.

I can understand why we would want to keep a Mr. Accessory on-hand over a Ms. Accessory and it also really sucks what happened.

I am wondering, though, should it just be made that all Mr. Store purchases should be excluded from the maximization process, not just the Ms. Accessory?

That's probably how I would like it, I wouldn't want a Mr. A to be spent on the latest IotM unless I specifically asked for it, even if it is a better option for what I'm maximizing than a Mr. Accessory.
 

Rinn

Developer
This should respect the price limit settings, and anything costing a mr. a should probably fail.
 

roippi

Developer
autoBuyPriceLimit will never be a protection against coinmaster purchases, since meat is not being spent.

We can hardcode something into maximizer to protect against this. That's a bummer.
 

Bale

Minion
autoBuyPriceLimit will never be a protection against coinmaster purchases, since meat is not being spent.

Many coinmaster tokens have a mall price, such as lunar isotopes, yeti furs, sand dollars and Mr. Accessories. For all tradeable tokens, their mall price could be compared to autoBuyPriceLimit. This would be a very worthwhile protection to add before making an automated coinmaster trade.
 

Catch-22

New member
Many coinmaster tokens have a mall price, such as lunar isotopes, yeti furs, sand dollars and Mr. Accessories

The trouble with using mall price as a metric is that it's value is entirely dependent upon the market. Just because the market says it's worth 2000 meat one day doesn't mean it's going to be worth 2000 the next.

If guess if you really wanted to stop your coinmaster tokens from being used, you should probably add them to the memento list.
 

roippi

Developer
Though, ok, hold on. For the maximizer to do that, you must have ticked the pullable/buyable radio button. And suggesting acquisition of Mr. store items is within the reasonable demesne of that button. Edit: or perhaps the creatable/foldable button, which is perhaps less immediately understandable but still expected behavior.

I can still hardcode something to make Ms. Accessories never creatable via maximizer, because that's explicitly bad.
 
Last edited:

Bale

Minion
Though, ok, hold on. For the maximizer to do that, you must have ticked the pullable/buyable radio button. And suggesting acquisition of Mr. store items is within the reasonable demesne of that button. Edit: or perhaps the creatable/foldable button, which is perhaps less immediately understandable but still expected behavior.

Actually, I wasn't suggesting that. I was suggesting that someone attempts to acquire an item, if that item's price exceeds autoBuyPriceLimit, mafia should abort even if it was trading tokens. That would have stopped this (and possibly other problems) from being automated.


I can still hardcode something to make Ms. Accessories never creatable via maximizer, because that's explicitly bad.

I can't argue with that.
 

roippi

Developer
Actually, I wasn't suggesting that. I was suggesting that someone attempts to acquire an item, if that item's price exceeds autoBuyPriceLimit, mafia should abort even if it was trading tokens. That would have stopped this (and possibly other problems) from being automated.

I know, I wasn't really aiming that post at you.

I understand what you're saying and it's generally a good idea. But it has problems. Mall price is a fickle thing and some things have very low sales volume - some item could arbitrarily skyrocket in price above its "real" value since it's hardly ever bought/sold and coinmaster requests would shut down until someone fixes it in the mall. Moreover, in order to avoid adding a lot of server hits, we'd have to go off of historical price - and if an outlier makes it in to there, it could shut down that coinmaster purchase for a long time. Not ideal.
 

xKiv

Active member
Shouldn't maximizer prefer on-hand items over buyable, if they have the same score?
I fact, isn't that already in MaximizerSpeculation.compareTo()? Except that CheckedItem.buyableFlag only gets set for *mall*-buyable stuff, not for coinmaster-buyable-stuff.
 

Nikadaemus

New member
I was going to start a new thread, but I can add to this. I am now the very unhappy owner of a Mr. Accessory Jr., as I also wasn't paying attention to the pullable/buyable choices Mafia made. I have always wondered, though, could we not have a separate category for each? Also, as it was stated, could we not exclude Mr. Store items from the list? That, or have a warning box come up?
 

lostcalpolydude

Developer
I'm thinking that
Code:
if ( itemId == ItemPool.MS_ACCESSORY )
should be changed to
Code:
if ( ( MrStoreRequest.MR_A ).equals( c.getIngredients()[0] ) )
in CheckedItem.
 
Top