This one is driving me a little insane, so advice, thoughts, help, investigation welcomed.
It appears to me at present that we create Modifiers in different ways. A Modifier has two pieces of data, a name and a value. Now, sometimes in constructing the modifier, the name is the name of the thing producing the modifier, eg Effect:Toxic Vengeance or Effect:[1818], and sometimes it is the name of the modifier being Modified, eg Muscle.
The only place I've found so far where the name really matters is that the name is used to work out if a character is under an effect. In this case, the first type of constructor works, the second fails.
My gut feeling is we should either have two different types of modifier, or an extra value, parent, which is filled in for the second type of constructor, and used for working out effect where present.
Either way, it looks messy, so would really appreciate a second pair of eyes!
It appears to me at present that we create Modifiers in different ways. A Modifier has two pieces of data, a name and a value. Now, sometimes in constructing the modifier, the name is the name of the thing producing the modifier, eg Effect:Toxic Vengeance or Effect:[1818], and sometimes it is the name of the modifier being Modified, eg Muscle.
The only place I've found so far where the name really matters is that the name is used to work out if a character is under an effect. In this case, the first type of constructor works, the second fails.
My gut feeling is we should either have two different types of modifier, or an extra value, parent, which is filled in for the second type of constructor, and used for working out effect where present.
Either way, it looks messy, so would really appreciate a second pair of eyes!