Bug Maximiser incorrectly reports miner's helmet better than Boris's helm with Lute equip

[FortyCakes]

This is using r11292. To reproduce equip a Boris's Helm in a Boris run, and have a miner's helmet as the only +item hat you have. On maximising for items the maximiser will recommend you equip the miner's helmet, but doing so will decrease your +item by a few percent.

 

[Theraze]

Aren't 'familiar' changes not considered in terms of maximizations? As such, miner's helmet is better for +items than Boris' helm, though the helm does provide a higher total +item overall...

Maybe that's changed since I remember that being noted. But if that's still the case, this is a FReq for that change rather than a bug, since you're asking for new mafia functionality.

 

[Bale]

Aren't 'familiar' changes not considered in terms of maximizations?

Not true! The maximizer will usually increase familiar's level when it helps maximize.

This is definitely a problem because it is treating Clancy different from the usual familiar. I'm not sure if that is a bug or a feature, to treat Clancy like he is a familiar.

 

[xKiv]

Not true! The maximizer will usually increase familiar's level when it helps maximize.

Well, it will not (yet) switch to a different familiar. But this was with the lute equipped.

Does maximizer offer other +Minstrel Level effects (song of accompaniment)[1] when that would increase the score?

[1] it would be at least decently awesome if mafia could detect that you have enough unspent boris points to get a passive skill like More to Love to increase score ... but that's probably overkill