Patch for review: View attachment 9912
Done: add filter checkboxes and add set all filters/clear filters buttons.
Done: Add filter field to results, so it's more like other panes.
Not sure if it's useful, but it's easy and might help. My best use case for it is "show me all the +20 ML results". Change to Scrollable Filtered Panel also affects Museum, but not in a bad way.
Done: Removing the Equipment: none radio button, since it's redundant with unchecking the equipment checkbox.
This may solve gausie's problem of not seeing "pullable/buyable" by making that row shorter. Downside of that: Removing the checkbox in the MaximizerFrame changes the Index of the options in the radio button. MaximizerFrame talks to the Maximizer by sending it that index as "equipLevel".
While I'd love to go in and rip out all of the "equipLevel" code and pass an Enum ("Enums are Integers, except when they're not") that's not on the plate for tonight, and I don't want to mess up the gCLI/ASH by changing the all those "if equipLevel == 1" lines to 0, or other fun things.
Immediate inelegant solution is to send RadioButtonGroupIndex+1...
Out of Scope: Anything about changing sort order
Out of Scope: Fixing the existing bug I'm about to report on text field focus when starting with a frame open.
This looks great MCroft, and works on my machine. You removed the copyright block in MaximizerFrame.java but I could reintroduce it before committing it.
For whatever reason though I feel like I should wait for Veracity to review it before merging - perhaps I'm just not confident with providing decent review for the very Javay bits of mafia