Bug - Fixed Limited AT Buff casts being double-counted?

Tokoeka

Member
Using r26916

Just cast via mafia 6 casts each of Ballad of Richie Thingfinder and Chorale of companionship as a Lvl 17 AT. (in both cases, 1 cast, followed by 5 casts). Mafia now believes both have been cast 10 times, and greys them out in the skill selector. However when I go to look at the skill casting page in the browser, it shows them both as only havign been cast 6/10 times (see attached image).

Checking the GCLI, I noticed for each cast via mafia, it appears to have been updating the relevant preference twice - see below:

Casting Chorale of Companionship 1 times...
You acquire an effect: Chorale of Companionship (25)
Preference _companionshipCasts changed from 0 to 1
Preference _companionshipCasts changed from 1 to 2
Chorale of Companionship was successfully cast.
Casting The Ballad of Richie Thingfinder 1 times...
You acquire an effect: The Ballad of Richie Thingfinder (25)
Preference _thingfinderCasts changed from 0 to 1
Preference _thingfinderCasts changed from 1 to 2
The Ballad of Richie Thingfinder was successfully cast.
Casting Chorale of Companionship 5 times...
You acquire an effect: Chorale of Companionship (125)
Preference _companionshipCasts changed from 2 to 6
Preference _companionshipCasts changed from 6 to 10
Chorale of Companionship was successfully cast.
Preference itemManagerIndex changed from 2 to 5
Casting The Ballad of Richie Thingfinder 5 times...
You acquire an effect: The Ballad of Richie Thingfinder (125)
Preference _thingfinderCasts changed from 2 to 6
Preference _thingfinderCasts changed from 6 to 10

Visiting the skills page did not update the preferences, but casting one of them from the page did update the relevant preference for that skill:

You acquire an effect: Chorale of Companionship (25)
Preference _companionshipCasts changed from 10 to 7

I have confirmed this does happen with Elron's Explosive Etude, Benetton's Medley, Donho's Bubby Ballad, Inigo's incantation, and Prelude of Precision
 

Veracity

Developer
Staff member
I see why that is happening.

For skills which tell you how many casts you have used per day, it sets the times cast to that number (which syncs us with KoL, in case we hadn't watched you do all those casts) - and then later it increments it.

Should be an easy fix.
 
Top